Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Fix nginx worker 100% cpu usage (spinning on write returning EAGAIN) #1481

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

oschaaf
Copy link
Member

@oschaaf oschaaf commented Sep 25, 2017

Bump the pipe capacity, because running out of buffer space may cause
a write to spin indefinitely on EAGAIN.
Bumping the pipe capacity should eliminate the problem in practice,
though in theory the module could still be subject to it.
For now, leaving behind a todo with a suggested solution (should
the problem ever show up again).

Fixes #1380

Bump the pipe capacity, because running out of buffer space may cause
a write to spin indefinitely on EAGAIN.
Bumping the pipe capacity should eliminate the problem in practice,
though in theory the module could still be subject to it.
For now, leaving behind a todo with a suggested solution (should
the problem ever show up again).

Fixes #1380
@oschaaf
Copy link
Member Author

oschaaf commented Sep 28, 2017

ping @keesspoelstra @ashishk-1 can one of you take a look at this?

Copy link

@ashishk-1 ashishk-1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me.

@oschaaf oschaaf merged commit 11f67d9 into master Sep 29, 2017
@oschaaf oschaaf deleted the oschaaf-issue-1380 branch September 29, 2017 07:06
@oschaaf
Copy link
Member Author

oschaaf commented Sep 29, 2017

thanks for taking a look @ashishk-1!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants