geo: fix unable to rewrite error geo encoded data bug #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shengofsun
reviewed
Aug 29, 2018
| cb(PERR_GEO_DECODE_VALUE_ERROR, pegasus_client::internal_info()); | ||
| return; | ||
| keep_geo_data = true; | ||
| dwarn_f("generate_geo_keys failed"); |
There was a problem hiding this comment.
应该把有问题的hashkey、sortkey、value也一起打出来？
There was a problem hiding this comment.
加到 geo_client::generate_geo_keys 函数里了，外层的就不重复加了
shengofsun
reviewed
Aug 29, 2018
| } | ||
|
|
||
| std::shared_ptr<int> ret = std::make_shared<int>(PERR_OK); | ||
| std::shared_ptr<std::atomic<int32_t>> del_count = | ||
| std::make_shared<std::atomic<int32_t>>(keep_common_data ? 1 : 2); | ||
| std::make_shared<std::atomic<int32_t>>(2); | ||
| if (keep_common_data) { |
There was a problem hiding this comment.
当时接口上留了keep_common_data的作用是？搜了一下貌似没发现用的，都是填的false
There was a problem hiding this comment.
有true的。作用是保留common table里的数据。在geo_client::async_set中，也就是写数据时，“keep”这条数据，因为是后面马上会overwrite他，可以少一次rpc
shengofsun
approved these changes
Aug 31, 2018
qinzuoyan
approved these changes
Sep 3, 2018
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
* fix unable to overwrite/remove error geo encoded value bug Former-commit-id: 282cd9f8d4fd9e6f15659265874a515908872ebe [formerly cfa1b9d] Former-commit-id: 7a080019d7bb67d43eec7664b81a078299322463
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geo set/del API will return error when operate on an exist data which is not encoded by a predefined rule， it's a bug