Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: compatibility dubbo 2.7.4+ #2239

Merged
merged 35 commits into from
Feb 12, 2020
Merged

feature: compatibility dubbo 2.7.4+ #2239

merged 35 commits into from
Feb 12, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

modify dubbo filter class name,compatibility dubbo 2.7.4.1

Ⅱ. Does this pull request fix one issue?

fixes #2194

funky-eyes and others added 29 commits December 11, 2019 19:57
@funky-eyes
Merge pull request #1 from seata/develop
f952112 
update
@funky-eyes
Merge pull request #2 from seata/develop
0c79faa 
同步代码
@funky-eyes
Merge pull request #3 from seata/develop
b407125 
同步源码
@funky-eyes
Merge pull request #4 from seata/develop
9f7f334 
同步源码
@funky-eyes
fix mysql connect unable to release bug
e363d82
@funky-eyes
Merge pull request #5 from seata/develop
3ce8bc0 
bugfix: fix mysql connection unable to release (apache#2037)
@funky-eyes
Merge pull request #6 from seata/develop
f3ce74f 
同步源码
@funky-eyes
Merge pull request #7 from seata/develop
4e90b5d 
同步源码
@funky-eyes
Merge pull request #8 from seata/develop
41f0817 
同步源码
@funky-eyes
Merge pull request #9 from seata/develop
ebd7464 
update
@funky-eyes
Merge pull request #10 from seata/develop
54a4b11 
update
@funky-eyes
Merge pull request #11 from seata/develop
2668c11 
update
@funky-eyes
Merge pull request #12 from seata/develop
6c6e2fc 
update
@funky-eyes
gracefully close resources
ae7ff61
@xingfudeshi
Merge branch 'develop' into develop
3ef5734
@lovepoem
Merge branch 'develop' into develop
0f109be
@funky-eyes
modify exceptionSerializer close the way
7177a25
@funky-eyes
Merge branch 'develop' of https://github.com/a364176773/seata into de…
4080ad5 
…velop
@lovepoem
Merge branch 'develop' into develop
62cb7f8
@zjinlei
Merge branch 'develop' into develop
2495ba2
@zjinlei
import sort
fac8a58
@funky-eyes
Merge pull request #13 from seata/develop
c768a93 
optimize: gracefully close resources (apache#2139)
@funky-eyes
Merge pull request #14 from seata/develop
c060630 
test: enhance test coverage of seata common (apache#2170)
@funky-eyes
Merge pull request #15 from seata/develop
a06cf2b 
update
@funky-eyes
Merge pull request #16 from seata/develop
7c8f175 
update
@funky-eyes
Merge pull request #17 from seata/develop
91185bb 
UPDATE
@funky-eyes
Merge pull request #18 from seata/develop
2114e57 
update
@funky-eyes
modify dubbo filter class name,compatibility dubbo 2.7.4.1
bf73075
@funky-eyes
optimized code
40dd141
@codecov-io
Copy link

codecov-io commented Feb 11, 2020 •
edited

Codecov Report

Merging #2239 into develop will increase coverage by 0.13%.
The diff coverage is 0%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2239      +/-   ##
=============================================
+ Coverage       53.6%   53.74%   +0.13%     
  Complexity      2620     2620              
=============================================
  Files            492      492              
  Lines          15395    15399       +4     
  Branches        1733     1765      +32     
=============================================
+ Hits            8253     8276      +23     
- Misses          6331     6335       +4     
+ Partials         811      788      -23
Impacted Files Coverage Δ Complexity Δ
.../java/io/seata/rm/datasource/DataCompareUtils.java 73.07% <0%> (-3.96%) 25 <0> (ø)
...buf/convertor/BranchRollbackResponseConvertor.java 100% <0%> (+2.94%) 3% <0%> (ø) ⬇️
...tobuf/convertor/BranchCommitResponseConvertor.java 100% <0%> (+3.03%) 3% <0%> (ø) ⬇️
...buf/convertor/GlobalRollbackResponseConvertor.java 100% <0%> (+3.22%) 3% <0%> (ø) ⬇️
...tobuf/convertor/GlobalStatusResponseConvertor.java 100% <0%> (+3.33%) 3% <0%> (ø) ⬇️
...tobuf/convertor/GlobalCommitResponseConvertor.java 100% <0%> (+3.33%) 3% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterRMResponseConvertor.java 82.75% <0%> (+3.44%) 3% <0%> (ø) ⬇️
...rotobuf/convertor/RegisterTMResponseConvertor.java 82.75% <0%> (+3.44%) 3% <0%> (ø) ⬇️
...uf/convertor/GlobalLockQueryResponseConvertor.java 100% <0%> (+3.84%) 3% <0%> (ø) ⬇️
...obuf/convertor/BranchRollbackRequestConvertor.java 100% <0%> (+4%) 3% <0%> (ø) ⬇️
... and 12 more

@slievrly slievrly added this to the 1.1.0 milestone Feb 11, 2020
slievrly
slievrly reviewed Feb 11, 2020
View reviewed changes
integration/dubbo-alibaba/pom.xml Outdated
@@ -39,5 +39,10 @@
<groupId>com.alibaba</groupId>
<artifactId>dubbo</artifactId>
</dependency>
<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependence is not appropriate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependence is not appropriate.

already modify @slievrly

...c/main/java/io/seata/integration/dubbo/alibaba/AlibabaDubboTransactionPropagationFilter.java Outdated

@Override
public Result invoke(Invoker<?> invoker, Invocation invocation) throws RpcException {
if (DubboConstants.ALIBABADUBBO) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of dependence on seata-dubbo (apache-dubbo), is it alibaba-dubbo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of dependence on seata-dubbo (apache-dubbo), is it alibaba-dubbo?

used to determine whether it is Alibaba or Apache @slievrly

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!DubboConstants.ALIBABADUBBO) {return invoker.invoke(invocation);}
reduce original changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if (!DubboConstants.ALIBABADUBBO) {return invoker.invoke(invocation);}
reduce original changes

get it

slievrly
slievrly approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xingfudeshi
xingfudeshi approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@xingfudeshi xingfudeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@slievrly slievrly changed the title compatibility dubbo 2.7.4.1 compatibility dubbo 2.7.4+ Feb 12, 2020
@slievrly slievrly changed the title compatibility dubbo 2.7.4+ feature: compatibility dubbo 2.7.4+ Feb 12, 2020
@slievrly slievrly merged commit 1bd9c1e into apache:develop Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zjinlei zjinlei zjinlei left review comments

@slievrly slievrly slievrly approved these changes

@xingfudeshi xingfudeshi xingfudeshi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

springboot dubbo TCC @Reference
6 participants
@funky-eyes @codecov-io @slievrly @zjinlei @xingfudeshi @lovepoem