Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: enhance test coverage of seata common #2170

Merged
merged 4 commits into from
Jan 11, 2020
Merged

test: enhance test coverage of seata common #2170

merged 4 commits into from
Jan 11, 2020

Conversation

caioguedes
Copy link
Contributor

Ⅰ. Describe what this PR did

Enhance the test coverage of seata-common module.

Ⅱ. Does this pull request fix one issue?

It's a partial fix of #187 .

Ⅲ. Why don't you add test cases (unit test/integration test)?

It adds tests... again... \o/

Ⅳ. Describe how to verify it

Run tests and coverage of seata-common module.

Ⅴ. Special notes for reviews

Should I update the Copyright 1999-2019 to 2020?

@codecov-io
Copy link

codecov-io commented Jan 10, 2020 •
edited

Codecov Report

Merging #2170 into develop will decrease coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2170      +/-   ##
=============================================
- Coverage      54.42%   54.27%   -0.15%     
- Complexity      2469     2471       +2     
=============================================
  Files            445      445              
  Lines          14742    14723      -19     
  Branches        1734     1695      -39     
=============================================
- Hits            8023     7991      -32     
+ Misses          5958     5951       -7     
- Partials         761      781      +20
Impacted Files Coverage Δ Complexity Δ
...obuf/convertor/BranchRegisterRequestConvertor.java 90.47% <0%> (-9.53%) 3% <0%> (ø)
...otobuf/convertor/BranchReportRequestConvertor.java 90.9% <0%> (-9.1%) 3% <0%> (ø)
...obuf/convertor/BranchRollbackRequestConvertor.java 92% <0%> (-8%) 3% <0%> (ø)
...otobuf/convertor/GlobalBeginResponseConvertor.java 92.59% <0%> (-7.41%) 3% <0%> (ø)
...otobuf/convertor/GlobalStatusRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...otobuf/convertor/GlobalCommitRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...obuf/convertor/GlobalRollbackRequestConvertor.java 93.75% <0%> (-6.25%) 3% <0%> (ø)
...protobuf/convertor/RegisterTMRequestConvertor.java 94.73% <0%> (-5.27%) 3% <0%> (ø)
...protobuf/convertor/RegisterRMRequestConvertor.java 90.47% <0%> (-4.77%) 3% <0%> (ø)
...tobuf/convertor/BranchReportResponseConvertor.java 95.45% <0%> (-4.55%) 3% <0%> (ø)
... and 20 more

zjinlei
zjinlei approved these changes Jan 11, 2020
View reviewed changes
Copy link
Contributor

@zjinlei zjinlei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

lovepoem
lovepoem approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@lovepoem lovepoem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lovepoem lovepoem merged commit 24185e5 into apache:develop Jan 11, 2020
funky-eyes added a commit to funky-eyes/seata that referenced this pull request Jan 12, 2020
@funky-eyes
Merge pull request #14 from seata/develop
c060630 
test: enhance test coverage of seata common (apache#2170)
dangquocbang pushed a commit to dangquocbang/seata that referenced this pull request Jan 14, 2020
Merge branch 'develop' of https://github.com/seata/seata into develop
521854e 
* 'develop' of https://github.com/seata/seata: (125 commits)
  optimize: tcc module code style (apache#2103)
  refactor: change the package path of MySQL recognizer (apache#2125)
  optimize: fix query typo (apache#2176)
  refactor: add sql parser type druid as constant (apache#2156)
  test: enhance test coverage of seata common (apache#2170)
  optimize: gracefully close resources (apache#2139)
  Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. (apache#2151)
  chore:use serializer instead of codec (apache#2097)
  optimize: spring module code style (apache#2159)
  optimize: Add Dubbo compatibility (apache#2036)
  optimize : seata-rm-datasource module code style (apache#2062)
  bugfix: Saga report branch status incorrect when service retried succeed (apache#2145)
  optimize:optimize log specifications (apache#2146)
  bugfix: when branchRollback failed, it will trigger retry of multi-tc. (apache#2113)
  refactor: create sql parser spi and a druid type sql parser (apache#1703)
  refactor: simplify to make seata-common more readable (apache#2038)
  feature: support FastThreadLocalContextCore (apache#2106)
  optimize: some typos (apache#2120)
  optimize: increase the oracle table meta cache code coverage (apache#2078)
  optimize: some typos (apache#2115)
  ...

# Conflicts:
#	pom.xml
@slievrly slievrly added this to the 1.1.0 milestone Feb 3, 2020
@funky-eyes
Copy link
Contributor

Due to the fact that some code authors did not sign the CLA in the early stage of Seata community governance norms, it may cause community intellectual property risk issues. Please help all contributors who have contributed code in the Seata community (including: main project, official website, samples, multilingual project, etc.) to log in to the github account at this link and sign the corresponding developer CLA, https://cla-assistant.io/seata/seata . 2023.1.31 The code that does not sign the CLA will be rewritten, please help sign it

@caioguedes
Copy link
Contributor Author

Due to the fact that some code authors did not sign the CLA in the early stage of Seata community governance norms, it may cause community intellectual property risk issues. Please help all contributors who have contributed code in the Seata community (including: main project, official website, samples, multilingual project, etc.) to log in to the github account at this link and sign the corresponding developer CLA, https://cla-assistant.io/seata/seata . 2023.1.31 The code that does not sign the CLA will be rewritten, please help sign it

Thanks @a364176773, CLA signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovepoem lovepoem lovepoem approved these changes

@zjinlei zjinlei zjinlei approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@caioguedes @codecov-io @funky-eyes @lovepoem @zjinlei @slievrly