optimize: gracefully close resources #2139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugfix: fix mysql connection unable to release (apache#2037)
Codecov Report
@@ Coverage Diff @@
## develop #2139 +/- ##
=============================================
- Coverage 54.4% 54.38% -0.02%
+ Complexity 2469 2467 -2
=============================================
Files 445 445
Lines 14742 14742
Branches 1734 1734
=============================================
- Hits 8020 8018 -2
Misses 5963 5963
- Partials 759 761 +2
|
xingfudeshi
reviewed
Jan 7, 2020
| ByteArrayOutputStream baos = new ByteArrayOutputStream(); | ||
| oos = new ObjectOutputStream(baos); | ||
| try (ByteArrayOutputStream baos = new ByteArrayOutputStream(); | ||
| ObjectOutputStream oos = new ObjectOutputStream(baos)) { |
There was a problem hiding this comment.
The close method of ByteArrayOutputStream actually does nothing.The close method of ObjectOutputStream should be called.
xingfudeshi
reviewed
Jan 7, 2020
...aga-engine-store/src/main/java/io/seata/saga/engine/serializer/impl/ExceptionSerializer.java
Outdated
Show resolved
Hide resolved
PTAL |
zjinlei
changed the title
funky-eyes
added a commit
to funky-eyes/seata
that referenced
this pull request
Jan 11, 2020
optimize: gracefully close resources (apache#2139)
slievrly
reviewed
Jan 12, 2020
| ByteArrayOutputStream baos = new ByteArrayOutputStream(); | ||
| oos = new ObjectOutputStream(baos); | ||
| ByteArrayOutputStream baos = new ByteArrayOutputStream(); | ||
| try (ObjectOutputStream oos = new ObjectOutputStream(baos)) { |
There was a problem hiding this comment.
if ObjectOutputStream close error , it will throw an exception?
dangquocbang
pushed a commit
to dangquocbang/seata
that referenced
this pull request
Jan 14, 2020
* 'develop' of https://github.com/seata/seata: (125 commits) optimize: tcc module code style (apache#2103) refactor: change the package path of MySQL recognizer (apache#2125) optimize: fix query typo (apache#2176) refactor: add sql parser type druid as constant (apache#2156) test: enhance test coverage of seata common (apache#2170) optimize: gracefully close resources (apache#2139) Feature: Saga provide a switch to skip branch report on branch success, in order to optimize performance. (apache#2151) chore:use serializer instead of codec (apache#2097) optimize: spring module code style (apache#2159) optimize: Add Dubbo compatibility (apache#2036) optimize : seata-rm-datasource module code style (apache#2062) bugfix: Saga report branch status incorrect when service retried succeed (apache#2145) optimize:optimize log specifications (apache#2146) bugfix: when branchRollback failed, it will trigger retry of multi-tc. (apache#2113) refactor: create sql parser spi and a druid type sql parser (apache#1703) refactor: simplify to make seata-common more readable (apache#2038) feature: support FastThreadLocalContextCore (apache#2106) optimize: some typos (apache#2120) optimize: increase the oracle table meta cache code coverage (apache#2078) optimize: some typos (apache#2115) ... # Conflicts: # pom.xml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.