Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zookeeper digest support #2245

Merged
merged 42 commits into from
Feb 14, 2020
Merged

zookeeper digest support #2245

merged 42 commits into from
Feb 14, 2020

Conversation

funky-eyes
Copy link
Contributor

Ⅰ. Describe what this PR did

zookeeper digest support

Ⅱ. Does this pull request fix one issue?

funky-eyes and others added 30 commits December 11, 2019 19:57
bugfix: fix mysql connection unable to release (apache#2037)
optimize: gracefully close resources (apache#2139)
test: enhance test coverage of seata common (apache#2170)
@codecov-io
Copy link

codecov-io commented Feb 13, 2020

Codecov Report

Merging #2245 into develop will decrease coverage by 0.01%.
The diff coverage is 56.14%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #2245      +/-   ##
=============================================
- Coverage      53.17%   53.16%   -0.02%     
+ Complexity      2647     2645       -2     
=============================================
  Files            505      505              
  Lines          15904    15904              
  Branches        1831     1831              
=============================================
- Hits            8457     8455       -2     
  Misses          6645     6645              
- Partials         802      804       +2
Impacted Files Coverage Δ Complexity Δ
...va/io/seata/rm/datasource/exec/UpdateExecutor.java 95.55% <0%> (ø) 11 <0> (ø) ⬇️
.../undo/postgresql/PostgresqlUndoUpdateExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...o/postgresql/keyword/PostgresqlKeywordChecker.java 89.52% <0%> (ø) 8 <0> (ø) ⬇️
.../undo/postgresql/PostgresqlUndoInsertExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
.../undo/postgresql/PostgresqlUndoDeleteExecutor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...tasource/undo/oracle/OracleUndoInsertExecutor.java 69.23% <100%> (ø) 3 <0> (ø) ⬇️
...datasource/undo/mysql/MySQLUndoDeleteExecutor.java 88.23% <100%> (ø) 5 <1> (ø) ⬇️
...tasource/undo/oracle/OracleUndoDeleteExecutor.java 88.23% <100%> (ø) 5 <1> (ø) ⬇️
...seata/rm/datasource/undo/AbstractUndoExecutor.java 69.44% <100%> (ø) 21 <0> (ø) ⬇️
...datasource/undo/mysql/MySQLUndoInsertExecutor.java 84.61% <100%> (ø) 4 <0> (ø) ⬇️
... and 49 more

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add properties in starter module.

@funky-eyes
Copy link
Contributor Author

add properties in starter module.

@slievrly PTAL

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jsbxyyx jsbxyyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsbxyyx jsbxyyx merged commit 4ac363f into apache:develop Feb 14, 2020
@slievrly slievrly added this to the 1.1.0 milestone Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants