-
Notifications
You must be signed in to change notification settings - Fork 8.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zookeeper digest support #2245
zookeeper digest support #2245
Conversation
bugfix: fix mysql connection unable to release (apache#2037)
optimize: gracefully close resources (apache#2139)
test: enhance test coverage of seata common (apache#2170)
Codecov Report
@@ Coverage Diff @@
## develop #2245 +/- ##
=============================================
- Coverage 53.17% 53.16% -0.02%
+ Complexity 2647 2645 -2
=============================================
Files 505 505
Lines 15904 15904
Branches 1831 1831
=============================================
- Hits 8457 8455 -2
Misses 6645 6645
- Partials 802 804 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add properties in starter module.
@slievrly PTAL |
...-discovery-zk/src/main/java/io/seata/discovery/registry/zk/ZookeeperRegisterServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ⅰ. Describe what this PR did
zookeeper digest support
Ⅱ. Does this pull request fix one issue?