Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix the exception when limit condition contains VariantRefExpr #3246

Merged

Conversation

caohdgege
Copy link
Contributor

@caohdgege caohdgege commented Oct 31, 2020

Ⅰ. Describe what this PR did

bugfix: fix the exception when limit condition contains VariantRefExpr

Ⅱ. Does this pull request fix one issue?

fixes #3251

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@caohdgege caohdgege changed the title bugfix: limit condition contains ? will throws ex bugfix: delte & update with limit condition contains ? will throws ex Oct 31, 2020
@caohdgege caohdgege changed the title bugfix: delte & update with limit condition contains ? will throws ex bugfix: delete & update with limit condition contains ? will throws ex Nov 1, 2020
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.4.0 milestone Nov 2, 2020
@funky-eyes funky-eyes added the module/rm-datasource rm-datasource module label Nov 2, 2020
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caohdgege caohdgege changed the title bugfix: delete & update with limit condition contains ? will throws ex bugfix: fix the exception when limit condition contains VariantRefExpr Nov 2, 2020
@slievrly slievrly merged commit e2685b8 into apache:develop Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/rm-datasource rm-datasource module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update and delete sql contains vars will cause ex
3 participants