Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: Druid disable oracle implicit cache #5098

Merged
merged 112 commits into from Nov 28, 2022
Merged

Conversation

miaoxueyu
Copy link
Contributor

@miaoxueyu miaoxueyu commented Nov 22, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

修复 seata1.5.2+oracle启动报java.sql.SQLException: 关闭的语句问题

Ⅱ. Does this pull request fix one issue?

fixes #5030

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

miaoxueyu and others added 30 commits January 6, 2022 00:07
# Conflicts:
#	server/src/main/java/io/seata/server/console/impl/file/GlobalSessionFileServiceImpl.java
@miaoxueyu miaoxueyu changed the title [WIP]bugfix: Oracle startup throws an exception: java.sql.SQLException: 关闭的语句问题 [WIP] bugfix: Oracle + druid startup throws an exception Nov 22, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2022

Codecov Report

Merging #5098 (fc92969) into develop (7aeff88) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head fc92969 differs from pull request most recent head fe08268. Consider uploading reports for the commit fe08268 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #5098   +/-   ##
==========================================
  Coverage      49.35%   49.35%           
  Complexity      4145     4145           
==========================================
  Files            737      737           
  Lines          26187    26188    +1     
  Branches        3233     3233           
==========================================
+ Hits           12924    12925    +1     
  Misses         11880    11880           
  Partials        1383     1383           
Impacted Files Coverage Δ
...io/seata/server/store/DruidDataSourceProvider.java 100.00% <100.00%> (ø)
...erver/storage/file/session/FileSessionManager.java 49.04% <0.00%> (-0.64%) ⬇️
...o/seata/server/coordinator/DefaultCoordinator.java 47.95% <0.00%> (+0.40%) ⬆️

@miaoxueyu miaoxueyu changed the title [WIP] bugfix: Oracle + druid startup throws an exception bugfix: Oracle + druid startup throws an exception Nov 27, 2022
@miaoxueyu miaoxueyu changed the title bugfix: Oracle + druid startup throws an exception bugfix: Druid disable oracle implicit cache Nov 28, 2022
Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slievrly slievrly added this to the 1.6.0 milestone Nov 28, 2022
@slievrly slievrly merged commit 8f83fdf into apache:develop Nov 28, 2022
zw201913 pushed a commit to zw201913/seata that referenced this pull request Dec 12, 2022
…o 1114_for_5073

* '1114_for_5073' of https://github.com/zw201913/seata:
  bugfix: hikari datasource auto proxy fail (apache#5134)
  bugfix: rollback active xa connection fail (apache#5131)
  optimize: support oracle on delete tccfence logs  (apache#5124)
  feature: support passing `contextPath` parameter to Nacos client (apache#5111)
  bugfix:NPE caused when there is no @GlobalTransactional annotation on the RM side  (apache#5109)
  bugfix: Druid disable oracle implicit cache (apache#5098)
  bugfix: fix access key loss after server restart (apache#5097)
  optimize: remove druid dependency in ConnectionProxy (apache#5104)
  bugfix:fix ClassNotFoundException during the ZK unit test (apache#5101)
  bugfix: fix when seata and jpa are used together, their AutoConfiguration order is incorrect (apache#5092)
  optimize: lock priority attempts to insert (apache#4681)
  bugfix: update join condition placeholder param error (apache#5052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

seata1.5.2+oracle启动报java.sql.SQLException: 关闭的语句
7 participants