Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix:fix ClassNotFoundException during the ZK unit test #5101

Merged
merged 6 commits into from Nov 24, 2022

Conversation

xingfudeshi
Copy link
Member

@xingfudeshi xingfudeshi commented Nov 23, 2022

  • I have registered the PR changes.

Ⅰ. Describe what this PR did

Cause ClassNotFoundException during the unit test of Zookeeper discovery

Ⅱ. Does this pull request fix one issue?

fixes #4768

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Run the ZookeeperRegisterServiceImplTest

Ⅴ. Special notes for reviews

# Conflicts:
#	changes/en-us/develop.md
#	changes/zh-cn/develop.md
@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2022

Codecov Report

Merging #5101 (29e05cb) into develop (cda49cc) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #5101      +/-   ##
=============================================
- Coverage      49.28%   49.25%   -0.04%     
+ Complexity      4133     4131       -2     
=============================================
  Files            737      737              
  Lines          26188    26188              
  Branches        3234     3234              
=============================================
- Hits           12906    12898       -8     
- Misses         11904    11912       +8     
  Partials        1378     1378              
Impacted Files Coverage Δ
...rage/redis/store/RedisTransactionStoreManager.java 72.06% <0.00%> (-2.09%) ⬇️
...erver/storage/file/session/FileSessionManager.java 49.04% <0.00%> (-0.64%) ⬇️
...very/registry/zk/ZookeeperRegisterServiceImpl.java 61.76% <0.00%> (+0.73%) ⬆️

Copy link
Contributor

@funky-eyes funky-eyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@funky-eyes funky-eyes added this to the 1.6.0 milestone Nov 23, 2022
@funky-eyes funky-eyes added type: bug Category issues or prs related to bug. module/discovery discovery module labels Nov 23, 2022
@xingfudeshi
Copy link
Member Author

Can be verified according to this
image

Copy link
Contributor

@wangliang181230 wangliang181230 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@l81893521 l81893521 merged commit 6673078 into apache:develop Nov 24, 2022
Copy link
Member

@slievrly slievrly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

zw201913 pushed a commit to zw201913/seata that referenced this pull request Dec 12, 2022
…o 1114_for_5073

* '1114_for_5073' of https://github.com/zw201913/seata:
  bugfix: hikari datasource auto proxy fail (apache#5134)
  bugfix: rollback active xa connection fail (apache#5131)
  optimize: support oracle on delete tccfence logs  (apache#5124)
  feature: support passing `contextPath` parameter to Nacos client (apache#5111)
  bugfix:NPE caused when there is no @GlobalTransactional annotation on the RM side  (apache#5109)
  bugfix: Druid disable oracle implicit cache (apache#5098)
  bugfix: fix access key loss after server restart (apache#5097)
  optimize: remove druid dependency in ConnectionProxy (apache#5104)
  bugfix:fix ClassNotFoundException during the ZK unit test (apache#5101)
  bugfix: fix when seata and jpa are used together, their AutoConfiguration order is incorrect (apache#5092)
  optimize: lock priority attempts to insert (apache#4681)
  bugfix: update join condition placeholder param error (apache#5052)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module/discovery discovery module type: bug Category issues or prs related to bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.ClassNotFoundException: org.eclipse.jetty.security.SecurityHandler in UT
6 participants