optimize: support oracle on delete tccfence logs #5124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
approved these changes
Dec 5, 2022
Codecov Report
@@ Coverage Diff @@
## develop #5124 +/- ##
=============================================
- Coverage 49.35% 48.99% -0.36%
- Complexity 4145 4169 +24
=============================================
Files 737 741 +4
Lines 26190 26521 +331
Branches 3232 3294 +62
=============================================
+ Hits 12925 12993 +68
- Misses 11881 12122 +241
- Partials 1384 1406 +22
|
wangliang181230
changed the title
zw201913
pushed a commit
to zw201913/seata
that referenced
this pull request
Dec 12, 2022
…o 1114_for_5073 * '1114_for_5073' of https://github.com/zw201913/seata: bugfix: hikari datasource auto proxy fail (apache#5134) bugfix: rollback active xa connection fail (apache#5131) optimize: support oracle on delete tccfence logs (apache#5124) feature: support passing `contextPath` parameter to Nacos client (apache#5111) bugfix:NPE caused when there is no @GlobalTransactional annotation on the RM side (apache#5109) bugfix: Druid disable oracle implicit cache (apache#5098) bugfix: fix access key loss after server restart (apache#5097) optimize: remove druid dependency in ConnectionProxy (apache#5104) bugfix:fix ClassNotFoundException during the ZK unit test (apache#5101) bugfix: fix when seata and jpa are used together, their AutoConfiguration order is incorrect (apache#5092) optimize: lock priority attempts to insert (apache#4681) bugfix: update join condition placeholder param error (apache#5052)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
支持oracle删除tccfence log。
在#4490 这个pr中对删除tccfence进行了优化，但是没考虑oracle的情况，所以用这个pr先支持oracle的删除。
特别说明：在4490pr里面新增了 query-by-date和delete-by-id之后，TCCFenceStoreDataBaseDAO .deleteTCCFenceDOByDate这个方法其实已经没有在使用，但由于初版的设计里对他也有改动，当时的pr里把deleteTCCFenceDOByDate里涉及的SQL语句和参数也增加了limit。这次把deleteTCCFenceDOByDate方法回滚还原回原来的样子直接支持oracle删除，而mysql等其他数据库由于不再使用这个dao方法也不会受影响。
Ⅱ. Does this pull request fix one issue?
fixes #5123
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews