bugfix: hikari datasource auto proxy fail #5134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
funky-eyes
requested review from
wangliang181230 and
xingfudeshi
and removed request for
wangliang181230
funky-eyes
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #5134 +/- ##
=============================================
- Coverage 49.35% 48.95% -0.40%
- Complexity 4145 4166 +21
=============================================
Files 737 741 +4
Lines 26190 26521 +331
Branches 3232 3294 +62
=============================================
+ Hits 12925 12984 +59
- Misses 11881 12129 +248
- Partials 1384 1408 +24
|
funky-eyes
added
type: bug
...ng-boot-starter/src/main/java/io/seata/spring/boot/autoconfigure/SeataAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...arter/src/main/java/io/seata/spring/boot/autoconfigure/SeataDataSourceAutoConfiguration.java
Outdated
Show resolved
Hide resolved
...arter/src/main/java/io/seata/spring/boot/autoconfigure/SeataDataSourceAutoConfiguration.java
Outdated
Show resolved
Hide resolved
zw201913
pushed a commit
to zw201913/seata
that referenced
this pull request
Dec 12, 2022
…o 1114_for_5073 * '1114_for_5073' of https://github.com/zw201913/seata: bugfix: hikari datasource auto proxy fail (apache#5134) bugfix: rollback active xa connection fail (apache#5131) optimize: support oracle on delete tccfence logs (apache#5124) feature: support passing `contextPath` parameter to Nacos client (apache#5111) bugfix:NPE caused when there is no @GlobalTransactional annotation on the RM side (apache#5109) bugfix: Druid disable oracle implicit cache (apache#5098) bugfix: fix access key loss after server restart (apache#5097) optimize: remove druid dependency in ConnectionProxy (apache#5104) bugfix:fix ClassNotFoundException during the ZK unit test (apache#5101) bugfix: fix when seata and jpa are used together, their AutoConfiguration order is incorrect (apache#5092) optimize: lock priority attempts to insert (apache#4681) bugfix: update join condition placeholder param error (apache#5052)
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
springboot的DataSourceAutoConfiguration优先级非常低,而seata SeataDataSourceAutoConfiguration 需要等到datasourcebean存在后再去代理,导致了优先级一定会高于DataSourceAutoConfiguration,DataSourceAutoConfiguration中有hikari的自动datasource装载,导致hikari的bean先加载后,Seata的SeataAutoDataSourceProxyCreator并没有进行构建,导致了二阶段如果rm重启了进行下发是找不到对应的rmchannel的.
1.5.2
1.6.0-SNAPSHOT 此pr的效果
对其他datasource无影响,如druid
Ⅱ. Does this pull request fix one issue?
fixes #4970
fixes #4976
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews