Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve]Trivial improvements #3723

Merged
merged 3 commits into from
May 27, 2024
Merged

[Improve]Trivial improvements #3723

merged 3 commits into from
May 27, 2024

Conversation

smallyao
Copy link
Contributor

What changes were proposed in this pull request

Issue Number: close #xxx

Brief change log

Trivial improvements

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): no

caicancai
caicancai previously approved these changes May 24, 2024
Copy link
Member

@caicancai caicancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smallyao
Copy link
Contributor Author

LGTM

Thanks @caicancai

@wolfboys wolfboys merged commit 3448cf0 into apache:dev May 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants