Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] job name validator improvement #3797

Merged
merged 8 commits into from
Jun 23, 2024
Merged

[Improve] job name validator improvement #3797

merged 8 commits into from
Jun 23, 2024

Conversation

wolfboys
Copy link
Member

[Improve] job name validator improvement

Contribution Checklist

  • If this is your first time, please read our contributor guidelines: Submit Code.

  • Make sure that the pull request corresponds to a GITHUB issue.

  • Name the pull request in the form "[Feature] Title of the pull request", where Feature can be replaced by Hotfix, Bug, etc.

  • Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.

  • If the PR is unfinished, add [WIP] in your PR title, e.g., [WIP][Feature] Title of the pull request.

What changes were proposed in this pull request

Issue Number: close #xxx

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@github-actions github-actions bot added the BUILD label Jun 22, 2024
@github-actions github-actions bot added the FLINK label Jun 22, 2024
Copy link
Member

@wangsizhu0504 wangsizhu0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangsizhu0504 wangsizhu0504 merged commit 65f20f5 into dev Jun 23, 2024
30 checks passed
@wolfboys wolfboys deleted the k8s-FE branch June 23, 2024 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants