Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: name+percent and name+value labels for piechart #3565

Merged

Conversation

Mogball
Copy link
Contributor

@Mogball Mogball commented Oct 2, 2017

As per #3048

Adds to Chart Options for Pie Chart two label types: Category and Percent and Category and Value which displays the percentages and values next to the category names on the chart:

Pie Chart labels GIF

@coveralls
Copy link

coveralls commented Oct 2, 2017

Coverage Status

Coverage remained the same at 70.161% when pulling b28cc65 on Mogball:mogball/feature/piechart_labels into bc3ad64 on apache:master.

@kkalyan
Copy link
Contributor

kkalyan commented Oct 2, 2017

awesome, thanks @Mogball!

@mistercrunch mistercrunch merged commit f8cc05b into apache:master Oct 2, 2017
@Stevie337
Copy link

How can this fix be implemented on the actual slice view? I am still only able to view the first 3 choices

@Mogball
Copy link
Contributor Author

Mogball commented Jan 15, 2018

Are you talking about the dashboard or explore view?

@Stevie337
Copy link

explore view

@Mogball
Copy link
Contributor Author

Mogball commented Jan 15, 2018

There should be 5 options on the label drop-down, unless this was broken in a later patch

@Stevie337
Copy link

I can only see 3 options

image

Version: {"GIT_SHA": "", "version": "0.20.0"}

@Mogball
Copy link
Contributor Author

Mogball commented Jan 15, 2018

I'm pretty sure this is a post 0.20.0 feature.

michellethomas pushed a commit to michellethomas/panoramix that referenced this pull request May 24, 2018
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.1 labels Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.20.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants