[Improvement] Add retry mechanism for reading data(memory/local/index) when there is no buffer #1606
Closed
3 tasks done
Comments
rickyma
changed the title
|
I think this is an improvement. |
rickyma
changed the title
rickyma
added a commit
to rickyma/incubator-uniffle
that referenced
this issue
Apr 1, 2024
…ta(memory/local/index) when there is no buffer
rickyma
added a commit
to rickyma/incubator-uniffle
that referenced
this issue
Apr 1, 2024
…ta(memory/local/index) when there is no buffer
rickyma
added a commit
to rickyma/incubator-uniffle
that referenced
this issue
Apr 1, 2024
…ta(memory/local/index) when there is no buffer
rickyma
added a commit
to rickyma/incubator-uniffle
that referenced
this issue
Apr 1, 2024
…ta(memory/local/index) when there is no buffer
rickyma
added a commit
to rickyma/incubator-uniffle
that referenced
this issue
Apr 1, 2024
…ta(memory/local/index) when there is no buffer
rickyma
added a commit
to rickyma/incubator-uniffle
that referenced
this issue
Apr 1, 2024
…ta(memory/local/index) when there is no buffer
zuston
pushed a commit
that referenced
this issue
Apr 8, 2024
…eading data(memory/local/index) (#1616) ### What changes were proposed in this pull request? 1. Remove server-side retry when reading data, and switch to client-side backoff retry; 2. Optimize lock contention issues when reading data, using CAS. ### Why are the changes needed? Fix #1606. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New UTs added. Tested in our env.
zhengchenyu
added a commit
to zhengchenyu/incubator-uniffle
that referenced
this issue
Sep 11, 2024
…ng data(memory/local/index)
zhengchenyu
added a commit
that referenced
this issue
Sep 23, 2024
…a(memory/local/index) (#2110) ### What changes were proposed in this pull request? Add retry mechanism tez. #1606 add retry mechanism, but forgot to add for tez. ### Why are the changes needed? Fix: #1606 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Code of Conduct
Search before asking
Describe the bug
There is no retry mechanism for clients to read data(memory/local/index) when there is no read memory on the server side.
Currently, retries will be performed on the server side, up to 50 times, with a sleep time of 1s each time. This means that a request may take more than 50s, which significantly affects the server's throughput in handling read requests.
Affects Version(s)
master
Uniffle Server Log Output
No response
Uniffle Engine Log Output
No response
Uniffle Server Configurations
No response
Uniffle Engine Configurations
No response
Additional context
No response
Are you willing to submit PR?
The text was updated successfully, but these errors were encountered: