Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] replace openjdk with alternatives as shuffle server's base image #600

Closed
2 of 3 tasks
advancedxy opened this issue Feb 15, 2023 · 0 comments · Fixed by #617
Closed
2 of 3 tasks

[Improvement] replace openjdk with alternatives as shuffle server's base image #600

advancedxy opened this issue Feb 15, 2023 · 0 comments · Fixed by #617

Comments

@advancedxy
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Quote from https://hub.docker.com/_/openjdk

This image is officially deprecated and all users are recommended to find and use suitable replacements ASAP. Some examples of other Official Image alternatives (listed in alphabetical order with no intentional or implied preference):

amazoncorretto
eclipse-temurin
ibm-semeru-runtimes
ibmjava
sapmachine
See docker-library/openjdk#505 for more information.

I believe we should replace openjdk with alternatives, eclipse-temurin sounds like a good fit.
Another catch about this: we should also make the base image as a docker build arg.

How should we improve?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
This was referenced Feb 16, 2023
Merged
Merged
advancedxy added a commit that referenced this issue Feb 21, 2023
@advancedxy
[#600] chore(operator): change JDK base from openjdk to eclipse-temur…
e20fb62 
…in (#617)

### What changes were proposed in this pull request?
1. replace openjdk with eclipse-temurin
2. split rss-server images into two parts: base and upper
3. fix lsof location in start.sh
4. enable rss-server image build on ci

### Why are the changes needed?
Fixes #600 

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Manually verified
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this issue Apr 5, 2023
@advancedxy
[apache#600] chore(operator): change JDK base from openjdk to eclipse…
4eb71f8 
…-temurin (apache#617)

### What changes were proposed in this pull request?
1. replace openjdk with eclipse-temurin
2. split rss-server images into two parts: base and upper
3. fix lsof location in start.sh
4. enable rss-server image build on ci

### Why are the changes needed?
Fixes apache#600 

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?
Manually verified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#600] chore(operator): change JDK base from openjdk to eclipse-temurin advancedxy/incubator-uniffle
1 participant
@advancedxy