Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Fetch Failed related exceptions should have a dedicated RssException class #750

Closed
3 tasks done
advancedxy opened this issue Mar 21, 2023 · 2 comments · Fixed by #751
Closed
3 tasks done

[Improvement] Fetch Failed related exceptions should have a dedicated RssException class #750

advancedxy opened this issue Mar 21, 2023 · 2 comments · Fixed by #751

Comments

@advancedxy
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

What would you like to be improved?

Currently, a lot of exception are all called RssException, which has no distinguish meanings.
When I'm implementing #477, I think we should at least to make fetch fetch exception a dedicated subclass.

How should we improve?

  1. define a new exception class
  2. when fetch failed occurred, throw the corresponding exception

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@advancedxy advancedxy mentioned this issue Mar 21, 2023
Merged
@kaijchen
Copy link
Contributor

Currently, a lot of exception are all called RssException, which has no distinguish meanings.

Thanks for the improvement. There are also many raw use of RuntimeException need to be replaced.

@advancedxy
Copy link
Contributor Author

Currently, a lot of exception are all called RssException, which has no distinguish meanings.

Thanks for the improvement. There are also many raw use of RuntimeException need to be replaced.

Yes, it's definitely worth refactor. Would you mind create an issue for this?

kaijchen pushed a commit that referenced this issue Mar 22, 2023
@advancedxy
[#750] feat: add RssFetchFailedException (#751)
7cb0b00 
### What changes were proposed in this pull request?
1. add a new exception called RssFetchFailedException
2. it's used in various instance creation

### Why are the changes needed?
Fix: #750

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Existing UTs.
xianjingfeng pushed a commit to xianjingfeng/incubator-uniffle that referenced this issue Apr 5, 2023
@advancedxy
[apache#750] feat: add RssFetchFailedException (apache#751)
f6edb68 
### What changes were proposed in this pull request?
1. add a new exception called RssFetchFailedException
2. it's used in various instance creation

### Why are the changes needed?
Fix: apache#750

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Existing UTs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#750] feat: add RssFetchFailedException advancedxy/incubator-uniffle
2 participants
@advancedxy @kaijchen