Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement ] Add rest api for shuffle server list of lost connection and unhealthy #937

Closed
3 tasks done
yl09099 opened this issue Jun 8, 2023 · 2 comments · Fixed by #938
Closed
3 tasks done

[Improvement ] Add rest api for shuffle server list of lost connection and unhealthy #937

yl09099 opened this issue Jun 8, 2023 · 2 comments · Fixed by #938

Comments

@yl09099
Copy link
Contributor

yl09099 commented Jun 8, 2023 •
edited
Loading

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Which parts of the documentation do you think need improvement?

Obtain the list of ServerNodes whose heartbeat is lost from a Coordinator Server,
Obtain the list of ServerNodes whose unhealthy from a Coordinator Server

Affects Version(s)

0.8.0

Improving the documentation

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!
@yl09099 yl09099 changed the title Add an interface to the shuffle server lost connection list [Improvement ]Add an interface to the shuffle server lost connection list Jun 8, 2023
@yl09099 yl09099 changed the title [Improvement ]Add an interface to the shuffle server lost connection list [Improvement ] Add an interface to the shuffle server lost connection list Jun 8, 2023
@jerqi
Copy link
Contributor

jerqi commented Jun 8, 2023

If you want to add an extra api, you would better add a rest api. You can refer to #931

@yl09099 yl09099 changed the title [Improvement ] Add an interface to the shuffle server lost connection list [Improvement ] Add a list of restful shuffle servers with lost connections and unhealthy servers Jun 8, 2023
@yl09099 yl09099 changed the title [Improvement ] Add a list of restful shuffle servers with lost connections and unhealthy servers [Improvement ] Add the shuffle server list of the server whose restful interface connection is lost and the server is unhealthy Jun 8, 2023
@yl09099 yl09099 changed the title [Improvement ] Add the shuffle server list of the server whose restful interface connection is lost and the server is unhealthy [Improvement ] Add rest api for shuffle server list of missing links and unhealthy servers Jun 8, 2023
@yl09099
Copy link
Contributor Author

yl09099 commented Jun 8, 2023

@jerqi I changed the title, I just want to add the rest api

@yl09099 yl09099 changed the title [Improvement ] Add rest api for shuffle server list of missing links and unhealthy servers [Improvement ] Add rest api for shuffle server list of missing links and unhealthy Jun 8, 2023
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 8, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
3725490 
…d unhealthy
@yl09099 yl09099 mentioned this issue Jun 8, 2023
Merged
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 8, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
1d613f3 
…d unhealthy
@jerqi jerqi changed the title [Improvement ] Add rest api for shuffle server list of missing links and unhealthy [Improvement ] Add rest api for shuffle server list of lost connection and unhealthy Jun 8, 2023
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 9, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
560998a 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 9, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
8ee2bd2 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 9, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
acbbc73 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 10, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
e325f69 
…d unhealthy
@jerqi jerqi mentioned this issue Jun 10, 2023
Merged
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 10, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
26ae5a4 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 10, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
3f2f430 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 10, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
be50016 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 11, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
f050089 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 11, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
6287675 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 11, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
6e29b6e 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 11, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
adde8be 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 12, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
46b7d08 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 13, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
3b1737e 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 14, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
74d1aee 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 14, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
02ae609 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 14, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
3c1f194 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 14, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
da252e5 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 14, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
3b9cbac 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 15, 2023
@yl09099
[apache#937] Add rest api for shuffle server list of missing links an…
05e0e1a 
…d unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 16, 2023
@yl09099
[apache#937] feat: Add rest api for servernode list of losing connect…
084bffb 
…ion and unhealthy
yl09099 added a commit to yl09099/incubator-uniffle that referenced this issue Jun 16, 2023
@yl09099
[apache#937] feat: Add rest api for servernode list of losing connect…
247864e 
…ion and unhealthy
jerqi pushed a commit that referenced this issue Jun 17, 2023
@yl09099
[#937] feat: Add rest api for servernode list of losing connection an…
0c3d60f 
…d unhealthy (#938)

### What changes were proposed in this pull request?
  Obtain the list of ServerNodes whose heartbeat is lost from a Coordinator Server
  Obtain the list of ServerNodes whose unhealthy from a Coordinator Server

### Why are the changes needed?
There is no interface for viewing lost and unhealthy lists

Fix: #937

### Does this PR introduce _any_ user-facing change?
  1. Change in user-facing APIs.

### How was this patch tested?
  Updated UT: SimpleClusterManagerTest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jerqi @yl09099