[#973] improvement: Make shuffle manager client RPC timeout configurable #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
reviewed
Jul 17, 2023
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java
Outdated
Show resolved
Hide resolved
jerqi
changed the title
jerqi
reviewed
Jul 18, 2023
common/src/main/java/org/apache/uniffle/common/config/RssBaseConf.java
Outdated
Show resolved
Hide resolved
…'POSITIVE_LONG_VALIDATOR'
Codecov Report
@@ Coverage Diff @@
## master #1017 +/- ##
============================================
+ Coverage 53.65% 54.83% +1.18%
- Complexity 2520 2527 +7
============================================
Files 382 362 -20
Lines 21647 19312 -2335
Branches 1798 1795 -3
============================================
- Hits 11614 10590 -1024
+ Misses 9328 8092 -1236
+ Partials 705 630 -75
... and 42 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
approved these changes
Jul 19, 2023
|
I don't think this works as expected, because we always new an |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Make shuffle manager client RPC timeout configurable
Why are the changes needed?
Fix: #973
Does this PR introduce any user-facing change?
No.
How was this patch tested?
current UT and Integration testing