[#1066] fix: The Jetty server fails to start when compiled with JDK 8 but runtime version is JDK 11. #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…version is JDK 11.
Codecov Report
@@ Coverage Diff @@
## master #1067 +/- ##
============================================
+ Coverage 54.18% 55.40% +1.22%
- Complexity 2549 2550 +1
============================================
Files 386 366 -20
Lines 21861 19507 -2354
Branches 1813 1813
============================================
- Hits 11845 10808 -1037
+ Misses 9315 8070 -1245
+ Partials 701 629 -72 see 25 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Do we need add this dependency to the coordinator's and shuffle server's pom? |
cchung100m
approved these changes
Aug 2, 2023
I verify this by hand. Binary package has the package |
jerqi
approved these changes
Aug 5, 2023
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the JDK 11 removed jar package.
Why are the changes needed?
Fix: #1066
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Tested in our cluster.