Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1805][part-2] Support Spark4 (Scala 2.13) #1814

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EnricoMi
Copy link
Contributor

@EnricoMi EnricoMi commented Jun 19, 2024

What changes were proposed in this pull request?

Adds Spark4 client.

Why are the changes needed?

Spark4 is about to be released. This tests that the existing Spark3 client is compatible with Spark4, and introduces a Spark3 client, which is a mere copy of the Spark3 client. Releasing an explicit Spark4 client will make it more obvious for users to pick the right client for their Spark4 environment.

Fix: #1805

Does this PR introduce any user-facing change?

It adds a Spark4 client, shaded client and integration tests.

How was this patch tested?

Existing Spark3 tests.

@EnricoMi
Copy link
Contributor Author

What do you think about the plain copy of Spark3 client?

@EnricoMi
Copy link
Contributor Author

EnricoMi commented Jun 19, 2024

How can we fix those nasty Kerberos failures with JDK 17?

java.io.IOException: Failed on local exception: java.io.IOException: javax.security.sasl.SaslException: GSS initiate failed [Caused by GSSException: No valid credentials provided (Mechanism level: Message stream modified (41) - Message stream modified)]; Host Details : local host is: "action-host/127.0.0.1"; destination host is: "localhost":40741;

https://github.com/apache/incubator-uniffle/runs/26438380881

Copy link

Test Results

 2 703 files  + 62   2 703 suites  +62   5h 30m 21s ⏱️ + 3m 42s
   948 tests +  5     941 ✅  -   1   1 💤 ±0  0 ❌ ±0  6 🔥 +6 
12 164 runs  +399  12 142 ✅ +392  16 💤 +1  0 ❌ ±0  6 🔥 +6 

For more details on these errors, see this check.

Results for commit a6ebf57. ± Comparison against base commit ea1070c.

@jerqi
Copy link
Contributor

jerqi commented Jun 20, 2024

What do you think about the plain copy of Spark3 client?

What do you think about the plain copy of Spark3 client?

It's ok for me.

@jerqi
Copy link
Contributor

jerqi commented Nov 14, 2024

What do you think about the plain copy of Spark3 client?

How can we fix those nasty Kerberos failures with JDK 17?

java.io.IOException: Failed on local exception: java.io.IOException: javax.security.sasl.SaslException: GSS initiate failed [Caused by GSSException: No valid credentials provided (Mechanism level: Message stream modified (41) - Message stream modified)]; Host Details : local host is: "action-host/127.0.0.1"; destination host is: "localhost":40741;

https://github.com/apache/incubator-uniffle/runs/26438380881

cc @zuston

@zuston
Copy link
Member

zuston commented Nov 14, 2024

From my sight, kerbreos is not ready for the JDK17. Maybe we could disble this in the java17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Support Spark 4
3 participants