Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-48][FEATURE][FOLLOW UP] Generate informer and lister for crd #202

Merged
merged 1 commit into from
Sep 6, 2022

Conversation

wangao1236
Copy link
Collaborator

What changes were proposed in this pull request?

for issue #48
I add some codes of crd's informer and lister generated by client-gen, and I will add controller module in the next pr.

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2022

Codecov Report

Merging #202 (55a881c) into master (331ebb2) will increase coverage by 0.07%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #202      +/-   ##
============================================
+ Coverage     58.41%   58.48%   +0.07%     
- Complexity     1273     1277       +4     
============================================
  Files           158      158              
  Lines          8448     8463      +15     
  Branches        784      785       +1     
============================================
+ Hits           4935     4950      +15     
+ Misses         3260     3259       -1     
- Partials        253      254       +1     
Impacted Files Coverage Δ
...org/apache/uniffle/server/ShuffleFlushManager.java 76.66% <0.00%> (-1.67%) ⬇️
...rg/apache/uniffle/coordinator/CoordinatorConf.java 96.39% <0.00%> (ø)
...rg/apache/uniffle/common/config/ConfigOptions.java 96.61% <0.00%> (+5.23%) ⬆️
.../org/apache/uniffle/common/config/ConfigUtils.java 34.44% <0.00%> (+12.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 07f70ed into apache:master Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants