Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test of ClientConfManagerTest #260

Merged
merged 1 commit into from
Oct 11, 2022

Conversation

smallzhongfeng
Copy link
Contributor

What changes were proposed in this pull request?

For https://github.com/apache/incubator-uniffle/actions/runs/3213433147/jobs/5253100348

org.opentest4j.AssertionFailedError: expected: <hdfs://host2/path2> but was: <hdfs://host3/path3>
	at org.junit.jupiter.api.AssertionUtils.fail(AssertionUtils.java:55)
	at org.junit.jupiter.api.AssertionUtils.failNotEqual(AssertionUtils.java:62)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:177)
	at org.junit.jupiter.api.Assertions.assertEquals(Assertions.java:1141)
	at org.apache.uniffle.coordinator.ClientConfManagerTest.dynamicRemoteByAppNumStrategyStorageTest(ClientConfManagerTest.java:200)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at 

This is because scheduling thread didn't update the remote path timely. For this test, we will trigger update logic manually.

Why are the changes needed?

Fix flaky test.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

UT passed.

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #260 (653aef6) into master (4b31e3d) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #260      +/-   ##
============================================
- Coverage     59.14%   59.13%   -0.02%     
+ Complexity     1342     1340       -2     
============================================
  Files           163      163              
  Lines          8837     8837              
  Branches        835      835              
============================================
- Hits           5227     5226       -1     
  Misses         3341     3341              
- Partials        269      270       +1     
Impacted Files Coverage Δ
...e/coordinator/AppBalanceSelectStorageStrategy.java 72.00% <0.00%> (-4.00%) ⬇️
...nator/LowestIOSampleCostSelectStorageStrategy.java 68.83% <0.00%> (-2.60%) ⬇️
...rg/apache/uniffle/storage/common/LocalStorage.java 44.82% <0.00%> (+2.06%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit fc6d49b into apache:master Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants