[ISSUE-369] Don't throw exception if blocks are corrupted but have multi replicas #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jerqi
reviewed
Nov 29, 2022
| @@ -82,6 +83,7 @@ public ShuffleReadClientImpl( | |||
| this.blockIdBitmap = blockIdBitmap; | |||
| this.taskIdBitmap = taskIdBitmap; | |||
| this.idHelper = idHelper; | |||
| this.shuffleServerInfoList = shuffleServerInfoList; | |||
There was a problem hiding this comment.
The size of shuffleServerInfoList will always be one because we use MultiReplicaReadHandler.
There was a problem hiding this comment.
No, shuffleServerInfoList has not be modified. You can check it again.
jerqi
reviewed
Nov 29, 2022
| if (expectedCrc != actualCrc) { | ||
| String errMsg = "Unexpected crc value for blockId[" + bs.getBlockId() | ||
| + "], expected:" + expectedCrc + ", actual:" + actualCrc; | ||
| if (shuffleServerInfoList.size() > 1) { |
There was a problem hiding this comment.
Could we add some comments here?
jerqi
changed the title
3 tasks
|
LGTM, just some nits. |
Codecov Report
@@ Coverage Diff @@
## master #374 +/- ##
============================================
- Coverage 58.01% 57.85% -0.16%
- Complexity 1361 1369 +8
============================================
Files 171 171
Lines 9006 9053 +47
Branches 787 794 +7
============================================
+ Hits 5225 5238 +13
- Misses 3449 3482 +33
- Partials 332 333 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
previously approved these changes
Nov 29, 2022
jerqi
approved these changes
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Don't throw exception if blocks are corrupted but have multi replicas
Why are the changes needed?
If some blocks of one replica are corrupted, maybe other replicas are not corrupted, so exception should not be thrown here if blocks have multi replicas. #369
Does this PR introduce any user-facing change?
No
How was this patch tested?
UT