[ISSUE-390] Print more infos after read finished #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
============================================
- Coverage 58.77% 58.53% -0.24%
- Complexity 1602 1604 +2
============================================
Files 193 194 +1
Lines 10939 10990 +51
Branches 955 962 +7
============================================
+ Hits 6429 6433 +4
- Misses 4132 4179 +47
Partials 378 378
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jerqi
reviewed
Dec 9, 2022
storage/src/main/java/org/apache/uniffle/storage/handler/impl/AbstractClientReadHandler.java
Outdated
Show resolved
Hide resolved
|
Could we add some uts for this pr? |
Done |
jerqi
approved these changes
Dec 10, 2022
3 tasks
jerqi
pushed a commit
that referenced
this pull request
Dec 12, 2022
### What changes were proposed in this pull request? Fix incorrect block info statistics after read finished ### Why are the changes needed? It is bug introduce by #395 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? No need
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
1.Print how much data the client read from each server.
2.Print how much data skipped.
Why are the changes needed?
Currently, we do not know how much data the client read from each server and how much data skipped #390
Does this PR introduce any user-facing change?
No
How was this patch tested?
Run Uts and check logs