Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-402] Flaky Test: QuorumTest#case1 #422

Merged
merged 1 commit into from
Dec 15, 2022
Merged

[ISSUE-402] Flaky Test: QuorumTest#case1 #422

merged 1 commit into from
Dec 15, 2022

Conversation

Rembrant777
Copy link
Contributor

What changes were proposed in this pull request?

Fix flaky test QuorumTest#case1

Why are the changes needed?

Improve QuorumTest#case1 integration test cases stability

Does this PR introduce any user-facing change?

No

How was this patch tested?

No need

@jerqi jerqi linked an issue Dec 14, 2022 that may be closed by this pull request
3 tasks
@jerqi jerqi changed the title Flaky Test: QuorumTest#case1 #402 [ISSUE-402] Flaky Test: QuorumTest#case1 Dec 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 14, 2022

Codecov Report

Merging #422 (f138f19) into master (d47f703) will increase coverage by 3.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #422      +/-   ##
============================================
+ Coverage     58.43%   61.52%   +3.08%     
  Complexity     1613     1613              
============================================
  Files           195      189       -6     
  Lines         11063     9902    -1161     
  Branches        976      976              
============================================
- Hits           6465     6092     -373     
+ Misses         4220     3492     -728     
+ Partials        378      318      -60     
Impacted Files Coverage Δ
...bernetes/operator/pkg/controller/controller/rss.go
...rnetes/operator/pkg/webhook/inspector/inspector.go
...y/kubernetes/operator/pkg/webhook/inspector/pod.go
deploy/kubernetes/operator/pkg/webhook/manager.go
...oy/kubernetes/operator/pkg/controller/util/util.go
...y/kubernetes/operator/pkg/webhook/inspector/rss.go

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense. LGTM, thanks @Rembrant777

@jerqi jerqi merged commit 877b4ed into apache:master Dec 15, 2022
@zuston
Copy link
Member

zuston commented Dec 15, 2022

Thanks. @Rembrant777

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky Test: QuorumTest#case1
4 participants