Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] Add ConfigUtilsTest #500

Merged
merged 5 commits into from
Jan 18, 2023
Merged

[Test] Add ConfigUtilsTest #500

merged 5 commits into from
Jan 18, 2023

Conversation

kaijchen
Copy link
Contributor

What changes were proposed in this pull request?

Add ConfigUtilsTest.

Why are the changes needed?

Improve test coverage.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

CI.

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2023

Codecov Report

Merging #500 (a2b7620) into master (6307ecb) will increase coverage by 0.50%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #500      +/-   ##
============================================
+ Coverage     58.83%   59.34%   +0.50%     
- Complexity     1707     1747      +40     
============================================
  Files           206      206              
  Lines         11508    11508              
  Branches       1030     1030              
============================================
+ Hits           6771     6829      +58     
+ Misses         4323     4274      -49     
+ Partials        414      405       -9     
Impacted Files Coverage Δ
.../org/apache/uniffle/common/util/UnitConverter.java 51.31% <0.00%> (+3.94%) ⬆️
.../org/apache/uniffle/common/config/ConfigUtils.java 95.55% <0.00%> (+61.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jerqi jerqi merged commit 9646a6f into apache:master Jan 18, 2023
@jerqi
Copy link
Contributor

jerqi commented Jan 18, 2023

Thanks @kaijchen

@kaijchen kaijchen deleted the config-utils-test branch January 18, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants