[SpotBugs] Fix UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD #536
Conversation
Codecov Report
@@ Coverage Diff @@
## master #536 +/- ##
============================================
- Coverage 60.23% 60.19% -0.04%
+ Complexity 1785 1784 -1
============================================
Files 205 205
Lines 11557 11561 +4
Branches 1042 1042
============================================
- Hits 6961 6959 -2
- Misses 4189 4194 +5
- Partials 407 408 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -35,8 +35,8 @@ public class CoordinatorGrpcMetrics extends GRPCMetrics { | |||
|
|
|||
| @Override | |||
| public void registerMetrics() { | |||
| gaugeGrpcOpen = metricsManager.addGauge(GRPC_OPEN); | |||
| counterGrpcTotal = metricsManager.addCounter(GRPC_TOTAL); | |||
| setGaugeGrpcOpen(metricsManager.addGauge(GRPC_OPEN)); | |||
There was a problem hiding this comment.
These two lines are same with ShuffleServer. isn't better to just initialize these metrics in parent class?
|
The code is fine with me. But I'm not sure why we treat |
It's written by different authors. Maybe because |
Nice catch. |
|
Thanks @advancedxy for the review. |
What changes were proposed in this pull request?
Remove UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD from
spotbugs-exclude.xmland fix violations.Why are the changes needed?
Sub-task of #532 - Fix UWF_UNWRITTEN_PUBLIC_OR_PROTECTED_FIELD.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI.