-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#552] docs: add more doc about spark.serializer requirement #556
Conversation
Codecov Report
@@ Coverage Diff @@
## master #556 +/- ##
============================================
+ Coverage 60.21% 60.85% +0.64%
- Complexity 1784 1795 +11
============================================
Files 205 213 +8
Lines 11557 12372 +815
Branches 1042 1050 +8
============================================
+ Hits 6959 7529 +570
- Misses 4190 4435 +245
Partials 408 408
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @advancedxy, I think the PR title needs to be changed, obviously this is not a |
It also involves code change, so I choose chore over docs. But |
|
In my opinion, anything trivial enough could go to the |
ping @jerqi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @advancedxy @kaijchen
What changes were proposed in this pull request?
add more doc and warning
Why are the changes needed?
Fixes #552
Does this PR introduce any user-facing change?
No
How was this patch tested?
No need.