[#410] feat: support the hot reload of coordinator's configuration #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jerqi
changed the title
jerqi
changed the title
|
Is this ready for review? |
OK. |
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
============================================
- Coverage 60.87% 60.87% -0.01%
- Complexity 1796 1799 +3
============================================
Files 213 214 +1
Lines 12375 12398 +23
Branches 1049 1051 +2
============================================
+ Hits 7533 7547 +14
- Misses 4435 4443 +8
- Partials 407 408 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Feb 9, 2023
common/src/main/java/org/apache/uniffle/common/config/Reconfigurable.java
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/config/ReconfigurableBase.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/config/ReconfigurableBase.java
Show resolved
Hide resolved
coordinator/src/main/java/org/apache/uniffle/coordinator/AccessManager.java
Show resolved
Hide resolved
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/config/Reconfigurable.java
Show resolved
Hide resolved
advancedxy
previously approved these changes
Feb 9, 2023
...or/src/main/java/org/apache/uniffle/coordinator/access/checker/AccessClusterLoadChecker.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/config/ReconfigurableBase.java
Outdated
Show resolved
Hide resolved
kaijchen
previously approved these changes
Feb 9, 2023
common/src/main/java/org/apache/uniffle/common/config/ReconfigurableBase.java
Outdated
Show resolved
Hide resolved
common/src/main/java/org/apache/uniffle/common/config/ReconfigurableBase.java
Outdated
Show resolved
Hide resolved
…urableBase.java Co-authored-by: Kaijie Chen <ckj@apache.org>
…urableBase.java Co-authored-by: Kaijie Chen <ckj@apache.org>
kaijchen
reviewed
Feb 10, 2023
common/src/main/java/org/apache/uniffle/common/config/ReconfigurableBase.java
Outdated
Show resolved
Hide resolved
…urableBase.java Co-authored-by: Kaijie Chen <ckj@apache.org>
advancedxy
approved these changes
Feb 10, 2023
|
Thanks @advancedxy @kaijchen , merged. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
I refer to Hadoop implement. I design a hot reload process. We support nodeMax at first.
Why are the changes needed?
It's more convenient.
Does this PR introduce any user-facing change?
add
rss.reconfigure.interval.sec.How was this patch tested?
UT