Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#580] chore: improve CI workflows #579

Merged
merged 12 commits into from
Feb 10, 2023
Merged

[#580] chore: improve CI workflows #579

merged 12 commits into from
Feb 10, 2023

Conversation

kaijchen
Copy link
Contributor

@kaijchen kaijchen commented Feb 10, 2023

What changes were proposed in this pull request?

  1. Cache maven dependencies with explicit cache-key.
  2. Cache go dependencies based on go.sum.
  3. Expand the sequential reusable workflow.
  4. Remove experimental option, as it's no longer needed.
  5. General cleanup.

Why are the changes needed?

Improve CI workflows. #580

Does this PR introduce any user-facing change?

No.

How was this patch tested?

https://github.com/kaijchen/incubator-uniffle/actions/runs/4140385049

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2023

Codecov Report

Merging #579 (815abbb) into master (b8d424d) will increase coverage by 0.28%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master     #579      +/-   ##
============================================
+ Coverage     60.85%   61.13%   +0.28%     
  Complexity     1798     1798              
============================================
  Files           213      213              
  Lines         12385    12328      -57     
  Branches       1051     1041      -10     
============================================
  Hits           7537     7537              
+ Misses         4439     4382      -57     
  Partials        409      409              
Impacted Files Coverage Δ
...torage/handler/impl/ComposedClientReadHandler.java 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@advancedxy
Copy link
Contributor

Thanks, well done @kaijchen

advancedxy
advancedxy previously approved these changes Feb 10, 2023
Copy link
Contributor

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just triggered the re-run job to see if there's any speedup.

@kaijchen
Copy link
Contributor Author

LGTM. I just triggered the re-run job to see if there's any speedup.

There won't be much speedup because dependencies are relatively small.
But the log will be cleaner.

@kaijchen kaijchen changed the title chore: improve CI workflows [#580] chore: improve CI workflows Feb 10, 2023
Copy link
Contributor

@advancedxy advancedxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaijchen kaijchen merged commit 6692516 into apache:master Feb 10, 2023
@kaijchen
Copy link
Contributor Author

Thanks @advancedxy for the review.

@kaijchen kaijchen deleted the ci branch February 10, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants