Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Add more unit tests in rss-common #63

Merged
merged 2 commits into from
Jul 21, 2022

Conversation

kaijchen
Copy link
Contributor

What changes were proposed in this pull request?

Add more unit tests in rss-common.

Why are the changes needed?

Improve coverage.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

By CI.

@codecov-commenter
Copy link

Codecov Report

Merging #63 (10d051d) into master (bdffcaa) will increase coverage by 1.26%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master      #63      +/-   ##
============================================
+ Coverage     55.15%   56.41%   +1.26%     
- Complexity     1112     1173      +61     
============================================
  Files           149      149              
  Lines          7969     7968       -1     
  Branches        761      761              
============================================
+ Hits           4395     4495     +100     
+ Misses         3332     3231     -101     
  Partials        242      242              
Impacted Files Coverage Δ
...he/uniffle/client/impl/ShuffleWriteClientImpl.java 26.05% <0.00%> (+0.09%) ⬆️
.../java/org/apache/uniffle/common/BufferSegment.java 100.00% <0.00%> (+3.84%) ⬆️
.../org/apache/uniffle/common/ShuffleIndexResult.java 100.00% <0.00%> (+14.28%) ⬆️
...apache/uniffle/common/ShufflePartitionedBlock.java 70.58% <0.00%> (+35.29%) ⬆️
...ava/org/apache/uniffle/common/RssShuffleUtils.java 93.33% <0.00%> (+46.66%) ⬆️
...a/org/apache/uniffle/common/ShuffleDataResult.java 81.81% <0.00%> (+81.81%) ⬆️
.../apache/uniffle/common/ShufflePartitionedData.java 81.81% <0.00%> (+81.81%) ⬆️
...va/org/apache/uniffle/common/ShuffleBlockInfo.java 87.17% <0.00%> (+87.17%) ⬆️
...a/org/apache/uniffle/common/ShuffleServerInfo.java 100.00% <0.00%> (+100.00%) ⬆️
...org/apache/uniffle/common/ShuffleRegisterInfo.java 100.00% <0.00%> (+100.00%) ⬆️

Copy link
Contributor

@jerqi jerqi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerqi jerqi merged commit 174e6bb into apache:master Jul 21, 2022
@kaijchen
Copy link
Contributor Author

Thanks @jerqi for the review.

@kaijchen kaijchen deleted the rss-common-test branch July 21, 2022 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants