[#632]fix: respect volumes in rss spec #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is bug fix, and it should also be included in branch-0.7. 😢 😭 cc @zuston |
Codecov Report
@@ Coverage Diff @@
## master #634 +/- ##
============================================
- Coverage 61.72% 60.90% -0.83%
- Complexity 1666 1799 +133
============================================
Files 201 214 +13
Lines 11105 12381 +1276
Branches 920 1042 +122
============================================
+ Hits 6855 7541 +686
- Misses 3876 4437 +561
- Partials 374 403 +29
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hi, @wangao1236 @jerqi please take a look. |
|
Is it duplicated with this pr? #466 |
No. They are two different issues. This is a bug fix. |
wangao1236
reviewed
Feb 21, 2023
| IsValidSts: func(sts *appsv1.StatefulSet, rss *uniffleapi.RemoteShuffleService) (valid bool, err error) { | ||
| for _, volume := range sts.Spec.Template.Spec.Volumes { | ||
| if volume.Name == testVolumeName { | ||
| return true, nil |
There was a problem hiding this comment.
Maybe we can compare the contents of your custom volume by deepcopy method?
There was a problem hiding this comment.
addressed. Please take a look again
wangao1236
approved these changes
Feb 21, 2023
jerqi
approved these changes
Feb 21, 2023
jerqi
pushed a commit
that referenced
this pull request
Feb 21, 2023
### What changes were proposed in this pull request? respect volumes for rss coordinator and shuffle server ### Why are the changes needed? This is a bug fix Fix: #632 ### Does this PR introduce _any_ user-facing change? Admin of rss cluster could specify the volumes which could be used to configure hadoop conf for example ### How was this patch tested? Added UTs.
|
merged master & branch-0.7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
respect volumes for rss coordinator and shuffle server
Why are the changes needed?
This is a bug fix
Fix: #632
Does this PR introduce any user-facing change?
Admin of rss cluster could specify the volumes which could be used to configure
hadoop conf for example
How was this patch tested?
Added UTs.