[#408] test: fix memory check failure in ShuffleBufferManagerTest#bufferSizeTest #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st#bufferSizeTest
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
============================================
+ Coverage 60.60% 62.84% +2.24%
- Complexity 1799 1800 +1
============================================
Files 216 202 -14
Lines 12458 10494 -1964
Branches 1052 1052
============================================
- Hits 7550 6595 -955
+ Misses 4500 3551 -949
+ Partials 408 348 -60 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Feb 25, 2023
| // Need to wait for `event.doCleanup` to be executed | ||
| // to ensure the correctness of subsequent checks of | ||
| // `shuffleBufferManager.getUsedMemory()` and `shuffleBufferManager.getInFlushSize()`. | ||
| Thread.sleep(100); |
There was a problem hiding this comment.
is there some way to ensure event.doCleanup is executed?
This still could be flaky. But I'm ok to merge if there's no easy way.
jerqi
reviewed
Feb 25, 2023
server/src/test/java/org/apache/uniffle/server/buffer/ShuffleBufferManagerTest.java
Show resolved
Hide resolved
advancedxy
approved these changes
Feb 27, 2023
|
@zuston Could you cherry-pick and commit to branch 0.7? |
zuston
added a commit
that referenced
this pull request
Mar 7, 2023
…ferSizeTest (#657) ### What changes were proposed in this pull request? Fix memory check failure due to the execution sequence in ShuffleBufferManagerTest#bufferSizeTest ### Why are the changes needed? Flaky test fix: #408 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
…st#bufferSizeTest (apache#657) ### What changes were proposed in this pull request? Fix memory check failure due to the execution sequence in ShuffleBufferManagerTest#bufferSizeTest ### Why are the changes needed? Flaky test fix: apache#408 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Existing UTs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Fix memory check failure due to the execution sequence in ShuffleBufferManagerTest#bufferSizeTest
Why are the changes needed?
Flaky test fix: #408
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing UTs