[#80][Part-2] feat: Add RPC logic and heartbeat logic for decommisson #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java
# Conflicts: # common/src/main/java/org/apache/uniffle/common/ServerStatus.java # common/src/main/java/org/apache/uniffle/common/exception/InvalidRequestException.java # coordinator/src/main/java/org/apache/uniffle/coordinator/CoordinatorServer.java # server/src/main/java/org/apache/uniffle/server/ShuffleServer.java # server/src/main/java/org/apache/uniffle/server/ShuffleServerConf.java
xianjingfeng
requested review from
advancedxy,
zuston,
jerqi and
kaijchen
and removed request for
advancedxy and
zuston
jerqi
reviewed
Feb 27, 2023
jerqi
reviewed
Feb 28, 2023
internal-client/src/main/java/org/apache/uniffle/client/request/RssDecommissionRequest.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #663 +/- ##
============================================
+ Coverage 60.67% 63.02% +2.34%
- Complexity 1802 1836 +34
============================================
Files 216 207 -9
Lines 12458 10677 -1781
Branches 1052 1067 +15
============================================
- Hits 7559 6729 -830
+ Misses 4494 3600 -894
+ Partials 405 348 -57
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
reviewed
Mar 1, 2023
common/src/main/java/org/apache/uniffle/common/ServerStatus.java
Outdated
Show resolved
Hide resolved
coordinator/src/main/java/org/apache/uniffle/coordinator/SimpleClusterManager.java
Outdated
Show resolved
Hide resolved
internal-client/src/main/java/org/apache/uniffle/client/request/RssDecommissionRequest.java
Outdated
Show resolved
Hide resolved
advancedxy
reviewed
Mar 1, 2023
common/src/main/java/org/apache/uniffle/common/ServerStatus.java
Outdated
Show resolved
Hide resolved
jerqi
approved these changes
Mar 2, 2023
|
Thanks @jerqi @advancedxy |
advancedxy
reviewed
Mar 2, 2023
| for (StatusCode statusCode : statusCodes) { | ||
| try { | ||
| RssProtos.StatusCode.valueOf(statusCode.name()); | ||
| } catch (Exception e) { | ||
| fail(e.getMessage()); | ||
| } | ||
| } | ||
| for (int i = 0; i < statusCodes.length; i++) { | ||
| assertEquals(protoStatusCode[i], statusCodes[i].toProto()); | ||
| for (int i = 0; i < statusCodes.size() - 1; i++) { |
There was a problem hiding this comment.
this should be restored to the original code since UNKNOWN has already been filtered out.
There was a problem hiding this comment.
Get. I will fix it in next pr of this feature.
advancedxy
reviewed
Mar 2, 2023
| fail(e.getMessage()); | ||
| } | ||
| } | ||
| for (int i = 0; i < serverStatuses.size() - 1; i++) { |
There was a problem hiding this comment.
ditto.. You may open a follow up pr for this.
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
…misson (apache#663) Add RPC logic and heartbeat logic for decommisson Support shuffle server decommission. It is a part of apache#80 No. UT
xianjingfeng
added a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…misson (apache#663) ### What changes were proposed in this pull request? Add RPC logic and heartbeat logic for decommisson ### Why are the changes needed? Support shuffle server decommission. It is a part of apache#80 ### Does this PR introduce any user-facing change? No. ### How was this patch tested? UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add RPC logic and heartbeat logic for decommisson
Why are the changes needed?
Support shuffle server decommission. It is a part of #80
Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT