[#729] improvement: use foreach when iterate Roaring64NavigableMap for better performance #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gableMap for better performance
zuston
changed the title
Codecov Report
@@ Coverage Diff @@
## master #730 +/- ##
============================================
+ Coverage 60.73% 62.89% +2.15%
+ Complexity 1859 1858 -1
============================================
Files 231 217 -14
Lines 12861 10893 -1968
Branches 1073 1071 -2
============================================
- Hits 7811 6851 -960
+ Misses 4635 3686 -949
+ Partials 415 356 -59
... and 15 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
cc @kaijchen |
|
The code itself looks good to me. Do you have any numbers or noticed this inefficiency in profiling . |
kaijchen
approved these changes
Mar 17, 2023
No, I just construct the data into bitmap and found that the |
Closed
3 tasks
advancedxy
pushed a commit
to advancedxy/incubator-uniffle
that referenced
this pull request
Mar 21, 2023
…vigableMap for better performance (apache#730) ### What changes were proposed in this pull request? use foreach when iterate over Roaring64NavigableMap for better performance ### Why are the changes needed? From the doc of RoaringBitmap/RoaringBitmap#44, it will reduce GC footprint and be faster when using the `foreach` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Don't need.
xianjingfeng
pushed a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…vigableMap for better performance (apache#730) ### What changes were proposed in this pull request? use foreach when iterate over Roaring64NavigableMap for better performance ### Why are the changes needed? From the doc of RoaringBitmap/RoaringBitmap#44, it will reduce GC footprint and be faster when using the `foreach` ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Don't need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
use foreach when iterate over Roaring64NavigableMap for better performance
Why are the changes needed?
From the doc of RoaringBitmap/RoaringBitmap#44, it will reduce gc footprint and be faster when using the
foreachDoes this PR introduce any user-facing change?
No.
How was this patch tested?
Don't need.