[#716] improvement(operator): support specifying imagePullSecrets #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 26, 2023 11:09
Codecov Report
@@ Coverage Diff @@
## master #765 +/- ##
=========================================
Coverage 60.72% 60.72%
Complexity 1905 1905
=========================================
Files 239 239
Lines 13038 13040 +2
Branches 1093 1093
=========================================
+ Hits 7917 7919 +2
Misses 4681 4681
Partials 440 440
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
advancedxy
approved these changes
Mar 27, 2023
xianjingfeng
added a commit
to xianjingfeng/incubator-uniffle
that referenced
this pull request
Apr 5, 2023
…ts (apache#765) ### What changes were proposed in this pull request? Support specifying imagePullSecrets ### Why are the changes needed? If the images are stored in a private registry, Kubernetes needs to be provided with the necessary credentials to authenticate with the registry. Fix: apache#716 ### Does this PR introduce any user-facing change? Example: apiVersion: uniffle.apache.org/v1alpha1 kind: RemoteShuffleService metadata: name: rss-demo namespace: rss spec: # ConfigMapName indicates configMap name stores configurations of coordinators and shuffle servers. configMapName: rss-configuration imagePullSecrets: - name: "default-secret" ### How was this patch tested? UT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Support specifying imagePullSecrets
Why are the changes needed?
If the images are stored in a private registry, Kubernetes needs to be provided with the necessary credentials to authenticate with the registry.
Fix: #716
Does this PR introduce any user-facing change?
Example:
How was this patch tested?
UT