[#343] improvement(build): Shade Netty Native lib #924
Conversation
cchung100m
changed the title
cchung100m
changed the title
jerqi
changed the title
|
We should only shade jars in the framework client like client-spark3, client-spark2, client-mr. You can modify |
jerqi
changed the title
Hi @jerqi Thanks for the prompt reply. I'd like to confirm whether the proposed change is feasible or not. |
Yes, I think it is feasible. Could you also modify the client-mr? |
Codecov Report
@@ Coverage Diff @@
## master #924 +/- ##
============================================
+ Coverage 55.29% 57.10% +1.81%
- Complexity 2273 2274 +1
============================================
Files 344 324 -20
Lines 16983 14623 -2360
Branches 1349 1349
============================================
- Hits 9391 8351 -1040
+ Misses 7048 5798 -1250
+ Partials 544 474 -70 see 23 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cchung100m
force-pushed
the
feat_343_Shade_Netty_Native_lib
branch
from
5f219f4
to
80c1fa1
Compare
|
Hi @jerqi It seems like there are some integration testing errors that occurred, any suggestions would be appreciated if you are available to help. |
server/pom.xml
Outdated
| @@ -203,6 +203,13 @@ | |||
| <pattern>com.fasterxml.jackson.databind</pattern> | |||
| <shadedPattern>${rss.shade.packageName}.jackson.databind</shadedPattern> | |||
| </relocation> | |||
| <relocation> | |||
There was a problem hiding this comment.
Could you revert this change?
There was a problem hiding this comment.
Hi @jerqi Thanks for the kind reminder and suggestions. I updated the part you mentioned.
…1410) ### What changes were proposed in this pull request? Fix a bug that was introduced from [#343](#343). The Netty native libraries have never been successfully shaded. PR [#924](#924) is not working at all. ### Why are the changes needed? For [#1409](#1409) ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? By running the RSS Netty client with Epoll mode successfully.
Hi @jerqi
Any comments and suggestions would be appreciated if you are available, thank you.
What changes were proposed in this pull request?
Add the shade Netty Native lib into
pom.xmlWhy are the changes needed?
Fix: #343
Does this PR introduce any user-facing change?
No.
How was this patch tested?
current UT