[#983] improvement(tez): Optimize tez client delivery configuration #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
============================================
+ Coverage 53.22% 54.58% +1.35%
- Complexity 2507 2512 +5
============================================
Files 376 356 -20
Lines 20535 18161 -2374
Branches 1758 1764 +6
============================================
- Hits 10930 9913 -1017
+ Misses 8920 7630 -1290
+ Partials 685 618 -67
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Should |
OK! modification is Done! |
baitian77
reviewed
Jul 3, 2023
baitian77
reviewed
Jul 3, 2023
| } | ||
|
|
||
| public static Configuration filterRssConf(Configuration extraConf) { | ||
| Configuration conf = new Configuration(); |
There was a problem hiding this comment.
Great catch! I do it like below. It is more clear.
Configuration conf = new Configuration(false);
There was a problem hiding this comment.
I think still need to call conf.clear(). Even if Configuration(false), will still load some configurations
There was a problem hiding this comment.
After test, it works without clear
jerqi
changed the title
baitian77
approved these changes
Jul 4, 2023
jerqi
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Three improvement about configuration will be done in this issue.
Why are the changes needed?
How was this patch tested?
integration test, unit test, test in yarn cluster, test in tez local mode.