Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

Improved README.md #1288

Closed
wants to merge 1 commit into from
Closed

Improved README.md #1288

wants to merge 1 commit into from

Conversation

erisu
Copy link
Member

@erisu erisu commented Jun 24, 2018 •
edited
Loading

This PR:

  • Bumped Node.js 4+ reference to 8+ to match with incubator-weex's engine requirement.
  • Centralized Prerequisites for All Platforms into its own section.
  • Wording improvements

@weex-bot
Copy link

weex-bot commented Jun 24, 2018 •
edited
Loading

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

Hanks10100
Hanks10100 reviewed Jun 26, 2018
View reviewed changes
README.md Outdated
* Run `weex init` to generate & start a simple project in an empty folder.
* Follow the instructions in the project README.
* Install [Weex Playground App](https://weex.apache.org/tools/playground.html) to see existing examples.
* Create your own examples by install [weex-toolkit](https://www.npmjs.com/package/weex-toolkit) with [Node.js](http://nodejs.org/) 6.0+.
Copy link
Contributor

@Hanks10100 Hanks10100 Jun 26, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the engines property in the package.json is ">=8", we can declare the version of node as 8.0+.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Hanks10100 Thanks for pointing it out. I will update it.

I thought originally, it was referencing the Node.js requirement of weex-toolkit which is currently >=6.0 in master, not the entire incubator-weex.

https://github.com/weexteam/weex-toolkit/blob/master/package.json#L13

@erisu
Copy link
Member Author

erisu commented Jun 26, 2018

@Hanks10100 I have updated the node version requirement. Please let me know if you see anything else.

@erisu
Improved README.md
bcfb0e6 
- Bumped Node.js 4+ reference to 8+ to match with incubator-weex's engine requirement.
- Centralized Prerequisites for All Platforms into its own section.
- Wording improvements
@asfgit asfgit closed this in 9ffdd04 Jun 26, 2018
wqyfavor pushed a commit to wqyfavor/incubator-weex that referenced this pull request Jun 27, 2018
@erisu
[doc] Improved README.md (resolve apache#1288)
c72dc7f 
- Bumped Node.js 4+ reference to 8+ to match with incubator-weex's engine requirement.
- Centralized Prerequisites for All Platforms into its own section.
- Wording improvements
wqyfavor pushed a commit to lucky-chen/incubator-weex that referenced this pull request Jul 3, 2018
Merge remote-tracking branch 'apache/master' into core-feature-bridge
cf484bd 
* apache/master: (32 commits)
  [WEEX-397][jsfm] update build script of js framework (apache#1199)
  [WEEX-479] Update jsbundle of weex playground app (resolve apache#1291)
  * [jsfm] using rollup.watch to fix dev build
  [WEEX-449][iOS] Fix issue that iconfont may randomly display as '?'.
  [WEEX-489][iOS] Fix resource not loaded when using dynamic framework solution in some cases.
  [jsfm] upgrade js framework to v0.26.18 (apache#1304)
  Revert "* [Android] Fix potential memory leak."
  [WEEX-462][Android] roll back method
  [WEEX-483][Android] get options from arguments in callNativeModule
  [WEEX-484][iOS] Failure of parsing transform parameter when in third-party environment
  [WEEX-445][jsfm] export requireModule to global
  [WEEX-342][android] when animation module or transition parser properties, some propers may be not right, so add try catch to handle the exceptions
  [android][WEEX-474] java.lang.IllegalArgumentException: pointerIndex out of range at com.taobao.weex.ui.view.WXCircleViewPager.dispatchTouchEvent(WXCircleViewPager.java:236)
  [android][WEEX-474] when the app's WXInstance destroy, but Weex page call toast Toast ,crash
  [WEEX-419][android] weeks bugfix for security check
  [WEEX-434][iOS]  Fix the input cannot move down to original position. Also fix issue that keyboard covers part of input when there is no navigation bar.
  [WEEX-446,447][iOS] Fix core text layout bug.
  * [Android] Fix duplication of animation initialization due to transformOrigin of CSS
  clean notices & fix web demo & add dependency of weex-vue-render. apache#1204.
  [doc] Improved README.md (resolve apache#1288)
  ...
@erisu erisu deleted the improve-readme branch April 4, 2019 06:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hanks10100 Hanks10100 Hanks10100 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erisu @weex-bot @Hanks10100