Skip to content
This repository has been archived by the owner on Jun 3, 2021. It is now read-only.

[iOS] Remove specific animation by key instead of removing all. If we… #1734

Merged
merged 1 commit into from
Nov 10, 2018

Conversation

wqyfavor
Copy link
Member

… don' t remove, updating transform won't work after doing CAAnimation. http://dotwe.org/vue/ce7d8d3bd4e67d3fe321c9e8b0bbbb7b

First of all, thank you for your contribution!

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

CheckList:

if isBugFix :

  • Make sure that you add at least one unit test for the bug which you had fixed.

elif isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update test scripts for the feature.
  • Add unit tests for the feature.

@weex-bot
Copy link

weex-bot commented Nov 10, 2018

Messages
📖 No android file has been changed.
📖 android build verification finished.

Generated by 🚫 dangerJS

@cxfeng1-zz cxfeng1-zz merged commit 8c6b3e6 into apache:master Nov 10, 2018
wqyfavor added a commit to wqyfavor/incubator-weex that referenced this pull request Nov 21, 2018
wqyfavor added a commit to wqyfavor/incubator-weex that referenced this pull request Nov 21, 2018
@wqyfavor wqyfavor deleted the fix-animationmodule branch November 23, 2018 06:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants