Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Manager] Rename OfflineJobSubmitRequest and remove log in controller #10589

Closed
2 tasks done
aloyszhang opened this issue Jul 9, 2024 · 0 comments · Fixed by #10590
Closed
2 tasks done

[Improve][Manager] Rename OfflineJobSubmitRequest and remove log in controller #10589

aloyszhang opened this issue Jul 9, 2024 · 0 comments · Fixed by #10590
Assignees
@aloyszhang
Labels
type/improve
Milestone
1.13.0

Comments

@aloyszhang
Copy link
Contributor

aloyszhang commented Jul 9, 2024 •
edited
Loading

Description

Some class names are not suitable like OfflineJobSubmitRequest.
Also, according to the convention, the controller shouldn't print logs.

InLong Component

InLong Manager

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
@aloyszhang aloyszhang changed the title [Improve][Manager] Rename OfflineJobSubmitRequest and remoe log in controller [Improve][Manager] Rename OfflineJobSubmitRequest and remove log in controller Jul 9, 2024
@aloyszhang aloyszhang self-assigned this Jul 9, 2024
@aloyszhang aloyszhang added this to the 1.13.0 milestone Jul 9, 2024
@aloyszhang aloyszhang mentioned this issue Jul 9, 2024
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aloyszhang aloyszhang

Labels
type/improve
Projects
None yet
Milestone
1.13.0
1 participant
@aloyszhang