Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-10589][Manager] Rename OfflineJobSubmitRequest and remove log in controller #10590

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

aloyszhang
Copy link
Contributor

@aloyszhang aloyszhang commented Jul 9, 2024

Fixes #10589

Motivation

Some class names are not suitable like OfflineJobSubmitRequest.
Also, according to the convention, the controller shouldn't print logs.

Modifications

  1. Rename OfflineJobSubmitRequest to OfflineJobRequest
  2. remove log in InlongGroupController

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

Documentation

  • Does this pull request introduce a new feature? (no)

@dockerzhang dockerzhang merged commit a8db0d2 into apache:master Jul 10, 2024
9 checks passed
@aloyszhang aloyszhang deleted the fix branch August 27, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve][Manager] Rename OfflineJobSubmitRequest and remove log in controller
3 participants