Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improve][Sort] Unify the constants in inlong-common and sort-connectors #6668

Closed
1 of 2 tasks
dockerzhang opened this issue Nov 29, 2022 · 5 comments · Fixed by #7864
Closed
1 of 2 tasks

[Improve][Sort] Unify the constants in inlong-common and sort-connectors #6668

dockerzhang opened this issue Nov 29, 2022 · 5 comments · Fixed by #7864
Assignees
@bibhu107
Labels
component/sort good first issue Good for newcomers type/improve
Milestone
1.7.0

Comments

@dockerzhang
Copy link
Contributor

Description

many constants defined in both, it's redundant, it's better to unify them, for example metrics.audit.proxy.hosts:

  • sort-connectors
    image

  • inlong-common
    image

InLong Component

InLong Sort

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct
@dockerzhang dockerzhang mentioned this issue Nov 29, 2022
Open
6 tasks
@seedscoder
Copy link
Contributor

If others don't start, please assign it to me

@seedscoder
Copy link
Contributor

seedscoder commented Dec 9, 2022 •
edited
Loading

Only extract the same key between the two modules? If these two modules have the same key as other modules, need to handle it？ @dockerzhang

@dockerzhang
Copy link
Contributor Author

@seedscoder it's better to think about it together.

@dockerzhang
Copy link
Contributor Author

@seedscoder do you start to solve this issue?

@bibhu107
Copy link
Contributor

Can I please take this issue @dockerzhang? Please assign it to me

bibhu107 added a commit to bibhu107/inlong that referenced this issue Apr 16, 2023
@bibhu107
Fixing issue apache#6668
99ff0d3
@bibhu107 bibhu107 mentioned this issue Apr 16, 2023
Merged
@dockerzhang dockerzhang assigned bibhu107 and unassigned seedscoder Apr 17, 2023
@dockerzhang dockerzhang added this to the 1.7.0 milestone Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bibhu107 bibhu107

Labels
component/sort good first issue Good for newcomers type/improve
Projects
None yet
Milestone
1.7.0
Development

Successfully merging a pull request may close this issue.

[INLONG-6668][Sort] Reusing existing constants bibhu107/inlong
3 participants
@dockerzhang @bibhu107 @seedscoder