Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TUBEMQ-172] simplify start/stop script #121

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Conversation

cku328
Copy link
Contributor

@cku328 cku328 commented Jun 2, 2020

I merged the features of the 2 scripts (master.sh/broker.sh), which support commands to start, stop and restart on either the master or broker server.

When the directory path is added to the path environment variable, it works like this:
image

I wonder if this solves the problem with this jira?

@dockerzhang
Copy link
Contributor

@cku328 good job. Could you please fix the user guide about start/stop at same time?

@cku328
Copy link
Contributor Author

cku328 commented Jun 3, 2020

Thanks @dockerzhang for the review.
I have updated the user guide.

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang
Copy link
Contributor

Thanks @cku328

@gosonzhang gosonzhang merged commit 25c5938 into apache:master Jun 3, 2020
@cku328
Copy link
Contributor Author

cku328 commented Jun 3, 2020

Thanks @gosonzhang for reviewing and merging this.

xuehuanran pushed a commit to xuehuanran/inlong that referenced this pull request Dec 22, 2022
…#121)

Co-authored-by: dockerzhang <dockerzhang@tencent.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants