[INLONG-1570] Provide a more elegant way to set the parameter of config #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## INLONG-25 #1578 +/- ##
==============================================
- Coverage 7.51% 7.48% -0.03%
Complexity 479 479
==============================================
Files 267 267
Lines 29500 29500
Branches 4843 4843
==============================================
- Hits 2216 2209 -7
- Misses 26810 26816 +6
- Partials 474 475 +1
Continue to review full report at Codecov.
|
charlely
reviewed
Sep 22, 2021
| @@ -744,3 +752,15 @@ func (c *consumer) closeAllBrokers() { | |||
| } | |||
| log.Infof("[CONSUMER] closeAllBrokers end, client=%s", c.clientID) | |||
| } | |||
|
|
|||
| // Invoke implementation of TubeMQ consumer. | |||
| func (c *consumer) Invoke(config *config.Config, opts ...config.Option) (Consumer, error) { | |||
There was a problem hiding this comment.
Maybe you can use NewConfig(opts ..config.Option) *config.Config is a good idea.
And use NewConsumer(config *config.Config) to start.
TszKitLo40
force-pushed
the
inlong-1570
branch
from
d4fc27d
to
6727bae
Compare
Signed-off-by: Zijie Lu <wslzj40@gmail.com>
TszKitLo40
force-pushed
the
inlong-1570
branch
from
6727bae
to
52ccb6c
Compare
charlely
approved these changes
Sep 22, 2021
dockerzhang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zijie Lu wslzj40@gmail.com
Title Name: [INLONG-XYZ][component] Title of the pull request
where XYZ should be replaced by the actual issue number.
Fixes #1570
Motivation
Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation