Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1641][Agent] introduce a Message filter #1641 #1644

Merged
merged 4 commits into from
Oct 15, 2021

Conversation

EMsnap
Copy link
Contributor

@EMsnap EMsnap commented Oct 14, 2021

Fixes #1641

Motivation

Agent introduce a Message filter

Modifications

Agent introduce a Message filter

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • Does this pull request introduce a new feature? (yes)

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2021

Codecov Report

Merging #1644 (66cfd7a) into master (7f7859a) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1644      +/-   ##
============================================
+ Coverage     12.19%   12.21%   +0.02%     
  Complexity     1048     1048              
============================================
  Files           392      392              
  Lines         32755    32755              
  Branches       5159     5159              
============================================
+ Hits           3994     4001       +7     
+ Misses        27995    27989       -6     
+ Partials        766      765       -1     
Impacted Files Coverage Δ
.../java/org/apache/flume/sink/tubemq/TubemqSink.java 55.42% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f7859a...66cfd7a. Read the comment docs.

@dockerzhang dockerzhang changed the title [INLONG-1592][1641] Agent introduce a Message filter #1641 [INLONG-1641][Agent] introduce a Message filter #1641 Oct 14, 2021
Copy link
Contributor

@dockerzhang dockerzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use @author in Apache project.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@aloyszhang aloyszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aloyszhang aloyszhang merged commit 32f2abf into apache:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] Agent introduce a Message filter
5 participants