Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1324][website] The consumption details should be refreshed after editin… #1674

Merged
merged 1 commit into from
Oct 19, 2021
Merged

Conversation

leezng
Copy link
Member

@leezng leezng commented Oct 19, 2021

Fixes #1324

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

@codecov-commenter
Copy link

Codecov Report

Merging #1674 (a1c8124) into master (7b2caf5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1674   +/-   ##
=========================================
  Coverage     12.21%   12.21%           
  Complexity     1048     1048           
=========================================
  Files           392      392           
  Lines         32755    32755           
  Branches       5159     5159           
=========================================
  Hits           4001     4001           
  Misses        27989    27989           
  Partials        765      765           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b2caf5...a1c8124. Read the comment docs.

@dockerzhang dockerzhang changed the title [INLONG-1324] The consumption details should be refreshed after editin… [INLONG-1324][website] The consumption details should be refreshed after editin… Oct 19, 2021
Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@dockerzhang dockerzhang merged commit 113a389 into apache:master Oct 19, 2021
@aloyszhang aloyszhang added this to the 0.11.0 milestone Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improve] [Manager] The consumption details should be refreshed after editing successfully
5 participants