Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1746][Dataproxy] [improve] the log4j properties for dataproxy contains some useless code and some class name are incorrect #1747

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

EMsnap
Copy link
Contributor

@EMsnap EMsnap commented Nov 4, 2021

Title Name: [INLONG-1746][Dataproxy] [improve] the log4j properties for dataproxy contains some useless code and some class name are incorrect

Fixes #1746

Motivation

the log4j properties for dataproxy contains some useless code and some class name are incorrect

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

Documentation

  • Does this pull request introduce a new feature? (no)

@codecov-commenter
Copy link

Codecov Report

Merging #1747 (bb949cc) into master (3e1696f) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1747      +/-   ##
============================================
+ Coverage     12.20%   12.21%   +0.01%     
+ Complexity     1050     1048       -2     
============================================
  Files           392      392              
  Lines         32755    32755              
  Branches       5159     5159              
============================================
+ Hits           3997     4001       +4     
+ Misses        27993    27989       -4     
  Partials        765      765              
Impacted Files Coverage Δ
.../inlong/tubemq/corebase/policies/FlowCtrlItem.java 38.88% <0.00%> (-1.12%) ⬇️
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 34.07% <0.00%> (-0.45%) ⬇️
.../java/org/apache/flume/sink/tubemq/TubemqSink.java 55.42% <0.00%> (+4.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e1696f...bb949cc. Read the comment docs.

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang assigned gosonzhang and EMsnap and unassigned gosonzhang Nov 4, 2021
@gosonzhang gosonzhang added this to the 0.12.0 milestone Nov 4, 2021
@gosonzhang gosonzhang merged commit 8e12b19 into apache:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[improve] the log4j properties for dataproxy contains some useless code and some class name are incorrect
4 participants