Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INLONG-1769][TubeMQ]Fix bug in util function SplitToMap in Go SDK #1770

Merged
merged 2 commits into from
Nov 9, 2021

Conversation

TszKitLo40
Copy link
Contributor

@TszKitLo40 TszKitLo40 commented Nov 8, 2021

Signed-off-by: Zijie Lu wslzj40@gmail.com

Title Name: [INLONG-XYZ][component] Title of the pull request

where XYZ should be replaced by the actual issue number.

Fixes #1769

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.
Fix panic in SplitToMap

Modifications

Describe the modifications you've done.
Use builtin function to implement SplitToMap

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a followup issue for adding the documentation

Signed-off-by: Zijie Lu <wslzj40@gmail.com>
@gosonzhang gosonzhang added the type/bug Something is wrong label Nov 9, 2021
@gosonzhang gosonzhang added this to the 0.12.0 milestone Nov 9, 2021
Signed-off-by: Zijie Lu <wslzj40@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1770 (103d3b5) into master (209bc63) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1770      +/-   ##
============================================
- Coverage     12.22%   12.21%   -0.01%     
+ Complexity     1050     1049       -1     
============================================
  Files           392      392              
  Lines         32764    32764              
  Branches       5157     5157              
============================================
- Hits           4004     4002       -2     
- Misses        27996    27998       +2     
  Partials        764      764              
Impacted Files Coverage Δ
.../inlong/tubemq/corebase/policies/FlowCtrlItem.java 38.88% <0.00%> (-1.12%) ⬇️
.../tubemq/corebase/policies/FlowCtrlRuleHandler.java 34.07% <0.00%> (-0.45%) ⬇️
.../producer/qltystats/DefaultBrokerRcvQltyStats.java 45.70% <0.00%> (+0.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 209bc63...103d3b5. Read the comment docs.

Copy link
Contributor

@gosonzhang gosonzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@gosonzhang gosonzhang merged commit 46188e8 into apache:master Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][TubeMQ]Util function SpitToMap in Go SDK panic
3 participants